Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove code deprecated in 0.21 (released on June 30, 2022) #10748

Closed
3 tasks
1ucian0 opened this issue Aug 31, 2023 · 2 comments · Fixed by #10754
Closed
3 tasks

Remove code deprecated in 0.21 (released on June 30, 2022) #10748

1ucian0 opened this issue Aug 31, 2023 · 2 comments · Fixed by #10754
Assignees
@Raghav-Bell
Labels
good first issue Good for newcomers

Comments

@1ucian0
Copy link
Member

1ucian0 commented Aug 31, 2023 •
edited
Loading

There is code released 13 month ago that needs to be removed.

  • qiskit/execute_function.py:39 (execute)
  • qiskit/execute_function.py:40 (execute)
  • qiskit/transpiler/passes/scheduling/alap.py:30 (__init__)
  • qiskit/transpiler/passes/scheduling/asap.py:36 (__init__)
  • qiskit/transpiler/passes/scheduling/dynamical_decoupling.py:93 (__init__)
  • qiskit/transpiler/passes/scheduling/alignments/align_measures.py:93 (__init__)
  • qiskit/transpiler/passes/utils/cx_direction.py:22 (__init__)
  • qiskit/transpiler/passes/utils/check_cx_direction.py:22 (__init__)
  • qiskit/algorithms/optimizers/spsa.py:652 (optimize) Not needed, as qiskit.algorithms has its own process.
  • qiskit/pulse/transforms/alignments.py:48 (to_dict)
  • qiskit/pulse/transforms/alignments.py:333 (to_dict)
  • qiskit/pulse/transforms/alignments.py:419 (to_dict)
  • qiskit/qpy/interface.py:75 (dump)

This includes:

  • Remove deprecated code and tests (if they only check the deprecation raise)
  • tag the PR as Changelog: Removal
  • create a release note in the category upgrade:. If you can include an example with an alternative for user to migrate to the new code, as this change might break users code.
@1ucian0 1ucian0 added the good first issue Good for newcomers label Aug 31, 2023
@Raghav-Bell
Copy link
Contributor

Please assign this issue to me.

@1ucian0
Copy link
Member Author

1ucian0 commented Aug 31, 2023

done @Raghav-Bell . Thanks!

@github-project-automation github-project-automation bot moved this to Tagged but unassigned in Contributor Monitoring Aug 31, 2023
@1ucian0 1ucian0 moved this from Tagged but unassigned to PR open / Contributor working on it in Contributor Monitoring Aug 31, 2023
@1ucian0 1ucian0 moved this from PR open / Contributor working on it to Assigned in Contributor Monitoring Aug 31, 2023
@Raghav-Bell Raghav-Bell mentioned this issue Sep 1, 2023
Merged
@github-project-automation github-project-automation bot moved this from Assigned to Done in Contributor Monitoring Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Raghav-Bell Raghav-Bell

Labels
good first issue Good for newcomers
Projects
Contributor Monitoring
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed code deprecated in qiskit-terra 0.21, released on June 2022 Raghav-Bell/qiskit-terra
2 participants
@1ucian0 @Raghav-Bell