Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing AdderGate class or remove references #13501

Closed
mtreinish opened this issue Nov 27, 2024 · 2 comments
Closed

Add missing AdderGate class or remove references #13501

mtreinish opened this issue Nov 27, 2024 · 2 comments
Labels
type: feature request New feature or request

Comments

@mtreinish
Copy link
Member

What should we add?

The 1.3.0 release notes referred to an AdderGate class, described as: "AdderGate implements standard addition including a carry-out" and this is also referred to in several docstrings for specific adder classes. But I have found no class definition for AdderGate. Either we should add the missing class or remove the references (I removed the release note for 1.3.0 in #13447 already)

@mtreinish mtreinish added the type: feature request New feature or request label Nov 27, 2024
@mtreinish mtreinish changed the title Add missing AdderGate class Add missing AdderGate class or remove references Nov 27, 2024
@alexanderivrii
Copy link
Contributor

There was an AdderGate class during the initial implementation, but it was later renamed to HalfAdderGate. Maybe we have indeed missed a few places.

@ShellyGarion
Copy link
Member

closed by #13502

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants