Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid redefining decompositions for non-parametric gates #1729

Closed
ajavadia opened this issue Jan 30, 2019 · 1 comment
Closed

Avoid redefining decompositions for non-parametric gates #1729

ajavadia opened this issue Jan 30, 2019 · 1 comment
Labels
type: enhancement It's working, but needs polishing

Comments

@ajavadia
Copy link
Member

What is the expected enhancement?

The unroller pass depends on decompositions that are defined per gate, and expands those gates according to those decomposition rules.

For gates such as crz, cu1, cu3, rx, ry, rz, rzz, u1, u2, u3, the decomposition depends on the parameter, and so each gate instance can have its own decomposition.

However, for all other gates, this is redundant and can start to add up. Instead, the decomposition should be defined once, for the class (not each instance).

@ajavadia
Copy link
Member Author

closing as covered by #3800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement It's working, but needs polishing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants