Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local simulators should generate results according to the result schema #755

Closed
delapuente opened this issue Aug 8, 2018 · 3 comments · Fixed by #1404
Closed

Local simulators should generate results according to the result schema #755

delapuente opened this issue Aug 8, 2018 · 3 comments · Fixed by #1404
Assignees
Labels
type: enhancement It's working, but needs polishing
Milestone

Comments

@delapuente
Copy link
Contributor

delapuente commented Aug 8, 2018

What is the expected enhancement?

In order to transition to using common standards, local simulators should report results following the proper schemas.

@delapuente
Copy link
Contributor Author

delapuente commented Aug 8, 2018

Not sure if the original commentary wanted to say this should be high-priority or it was just pressing for moving to a separate issue as soon as possible. @ajavadia can you clarify this?

captura de pantalla 2018-08-08 a las 19 36 45

@delapuente delapuente changed the title Local simualtors generate new qobj Local simualtors should generate results according to the result schema Aug 9, 2018
@delapuente delapuente changed the title Local simualtors should generate results according to the result schema Local simulators should generate results according to the result schema Aug 9, 2018
@ajavadia ajavadia self-assigned this Aug 30, 2018
@jaygambetta
Copy link
Member

@delapuente and @ajavadia I think we make this 0.7.

@diego-plan9
Copy link
Member

I think it makes sense - at the moment, they still use the old result format internally, and make use of result_from_old_style_dict() for converting to the new result schema. Eventually they need to be updated, but since they do work, let's assign it to the 0.7 milestone - @delapuente and @ajavadia , please revert if this is not correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement It's working, but needs polishing
Projects
None yet
4 participants