Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema test test_schemas.py is not a test #834

Closed
delapuente opened this issue Aug 28, 2018 · 3 comments
Closed

Schema test test_schemas.py is not a test #834

delapuente opened this issue Aug 28, 2018 · 3 comments
Assignees
@taalexander
Labels
type: enhancement It's working, but needs polishing type: qa Issues and PRs that relate to testing and code quality

Comments

@delapuente
Copy link
Contributor

Schema validation tests tests/schemas/test_schemas.py should be a test to be run with all the regular tests.
@delapuente delapuente added type: enhancement It's working, but needs polishing type: qa Issues and PRs that relate to testing and code quality labels Aug 28, 2018
@taalexander
Copy link
Contributor

@delapuente I can take this issue and put together a PR after the merge of #807.

@delapuente
Copy link
Contributor Author

Great, @taalexander! Thank you.

@delapuente delapuente mentioned this issue Sep 3, 2018
Merged
@taalexander taalexander mentioned this issue Sep 10, 2018
Merged
@diego-plan9
Copy link
Member

Seems this was closed by #886 - please reopen otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taalexander taalexander

Labels
type: enhancement It's working, but needs polishing type: qa Issues and PRs that relate to testing and code quality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@diego-plan9 @delapuente @taalexander