Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 0.9.0 release #339

Merged
merged 21 commits into from
Jun 1, 2021
Merged

Prepare 0.9.0 release #339

merged 21 commits into from
Jun 1, 2021

Conversation

mtreinish
Copy link
Member

@mtreinish mtreinish commented May 27, 2021

This commit starts the preparation for the 0.9.0 release. It moves all
the release notes for the release into a separate folder (to distinguish
them from notes for future releases) and also reworks the content of the
release notes and updates the documentation for the release. This commit
should be the last one merged before releasing 0.9.0 to ensure we've
moved and updated all the release notes before the release.

Fixes #328

@mtreinish mtreinish added this to the 0.9.0 milestone May 27, 2021
@coveralls
Copy link

coveralls commented May 27, 2021

Pull Request Test Coverage Report for Build 895570368

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 18 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+1.03%) to 96.865%

Files with Coverage Reduction New Missed Lines %
src/lib.rs 18 99.32%
Totals Coverage Status
Change from base Build 893685123: 1.03%
Covered Lines: 8714
Relevant Lines: 8996

💛 - Coveralls

@mtreinish
Copy link
Member Author

Leaving this as on hold until we're ready to release 0.9.0 since we'll want to merge this last

@mtreinish
Copy link
Member Author

@ajavadia updated the class docstrings as part of this PR to make how node and edge indices work a bit clearer. Let me know if I need to tweak it more.

Copy link
Contributor

@elfrocampeador elfrocampeador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the language is a bit awkward. I've suggested some alternatives

Copy link
Collaborator

@IvanIsCoding IvanIsCoding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor grammar corrections.

mtreinish and others added 18 commits May 31, 2021 14:02
This commit starts the preparation for the 0.9.0 release. It moves all
the release notes for the release into a separate folder (to distinguish
them from notes for future releases) and also reworks the content of the
release notes and updates the documentation for the release. This commit
should be the last one merged before releasing 0.9.0 to ensure we've
moved and updated all the release notes before the release.

Partially implements Qiskit#328
@mtreinish
Copy link
Member Author

mtreinish commented May 31, 2021

Ok, all the tracked PRs have merged so this is unblocked now. Once this is approved and merged I'll tag main as the 0.9.0 release.

@mtreinish mtreinish merged commit 010e0de into Qiskit:main Jun 1, 2021
@mtreinish mtreinish deleted the prepare-0.9 branch June 1, 2021 11:01
mtreinish added a commit to mtreinish/retworkx that referenced this pull request Jun 16, 2021
This commit fixes the tox job configuration so we actually install the
requirements for running the graphviz drawer tests. To run the graphviz
drawer tests you need graphviz installed in addition to the retworkx
extras requirements 'graphviz' (which contains pillow and pydot).
However, prior to Qiskit#339 the extra was called 'pydot' not 'graphviz' and
this was never updated in the tox.ini. This has resulted in the graphivz
drawer tests all being skipped because we're not installing the python
requirements in the test environment. This commit fixes this oversight
and configures tox to install the correct extra so we can run the tests
(at least on linux where we install graphviz in CI).
mtreinish added a commit that referenced this pull request Jun 16, 2021
This commit fixes the tox job configuration so we actually install the
requirements for running the graphviz drawer tests. To run the graphviz
drawer tests you need graphviz installed in addition to the retworkx
extras requirements 'graphviz' (which contains pillow and pydot).
However, prior to #339 the extra was called 'pydot' not 'graphviz' and
this was never updated in the tox.ini. This has resulted in the graphivz
drawer tests all being skipped because we're not installing the python
requirements in the test environment. This commit fixes this oversight
and configures tox to install the correct extra so we can run the tests
(at least on linux where we install graphviz in CI).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation overhaul
4 participants