Fix execution of graphivz tests in CI #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the tox job configuration so we actually install the requirements for running the graphviz drawer tests. To run the graphviz drawer tests you need graphviz installed in addition to the retworkx extras requirements 'graphviz' (which contains pillow and pydot). However, prior to Qiskit#339 the extra was called 'pydot' not 'graphviz' and this was never updated in the tox.ini. This has resulted in the graphivz drawer tests all being skipped because we're not installing the python requirements in the test environment. This commit fixes this oversight and configures tox to install the correct extra so we can run the tests (at least on linux where we install graphviz in CI).
|
The tests are running again now: https://github.com/Qiskit/retworkx/pull/364/checks?check_run_id=2838488448#step:7:1088 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the tox job configuration so we actually install the
requirements for running the graphviz drawer tests. To run the graphviz
drawer tests you need graphviz installed in addition to the retworkx
extras requirements 'graphviz' (which contains pillow and pydot).
However, prior to #339 the extra was called 'pydot' not 'graphviz' and
this was never updated in the tox.ini. This has resulted in the graphivz
drawer tests all being skipped because we're not installing the python
requirements in the test environment. This commit fixes this oversight
and configures tox to install the correct extra so we can run the tests
(at least on linux where we install graphviz in CI).