Add dijkstra-search #489
Merged
Add dijkstra-search #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements a `dijkstra_search` that traverses a graph using Dijkstra algorithm and provides the ability to insert callback functions at specified event points. Python users should subclass `retworkx.visit.DijkstraVisitor` and overwrite the appropriate callback functions.
There was a problem hiding this comment.
Thanks for this, after #456 and #469 this feels natural and it will be a great addition.
One thing I would like to debate is not replacing our current implementation of Dijkstra, I understand it is shorter but I find it harder to maintain. It feels less straightforward with details hidden on another part of the code.
Pull Request Test Coverage Report for Build 1698719141
💛 - Coveralls |
Merged
IvanIsCoding
requested changes
Jan 11, 2022
IvanIsCoding
approved these changes
Jan 14, 2022
InnovativeInventor
pushed a commit
to InnovativeInventor/retworkx
that referenced
this pull request
Mar 19, 2022
* Add dijkstra-search This commit implements a `dijkstra_search` that traverses a graph using Dijkstra algorithm and provides the ability to insert callback functions at specified event points. Python users should subclass `retworkx.visit.DijkstraVisitor` and overwrite the appropriate callback functions. * remove unnecessary test file * revert changes in `dijkstra.rs` * cargo fmt * deduplicate `try_control` macro * raise if negative weight * fix release note Co-authored-by: Matthew Treinish <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements a
dijkstra_searchthat traverses a graphusing Dijkstra algorithm and provides the ability to insert callback
functions at specified event points. Python users should subclass
retworkx.visit.DijkstraVisitorand overwrite the appropriate callback functions.