Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rfc2217: do not set logger = None inside open() #397

Open
Qlexio opened this issue Jan 27, 2025 · 0 comments
Open

rfc2217: do not set logger = None inside open() #397

Qlexio opened this issue Jan 27, 2025 · 0 comments

Comments

@Qlexio
Copy link
Owner

Qlexio commented Jan 27, 2025

The logger field is already initialized inside __init__ so no need to do it again.

It is possible for the user to initialize logger after __init__ and before open(), if that happens then we should log all negotiation messages. Right now they are always lost, it is impossible to log negotiation messages.


This issue has been cloned from: pyserial#764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant