Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public IP should be resource address if exists #245

Open
alonagetzler opened this issue Aug 7, 2016 · 1 comment
Open

Public IP should be resource address if exists #245

alonagetzler opened this issue Aug 7, 2016 · 1 comment

Comments

@alonagetzler
Copy link
Contributor

alonagetzler commented Aug 7, 2016

in case the VM has only private IP it should be the resource address
in case the VM has a private IP and a public IP (elastic or public) it should become the resource address

we should add a "Private IP" attribute on the deployed app and store the private ip there regardless if there is a public ip or not

QualiX should use the private ip attribute instead of the resource address

==> TBD, need to understand if that is indeed required

Roni: It didn't make sense to me when I saw it. I expected the address on the resource to be the 'front' facing address. Public when available and private when not. It also makes it clearer which instance is public and which isn't.

@alonagetzler alonagetzler changed the title TBD - Public IP should be resource address Public IP should be resource address if exists Aug 21, 2016
@alonagetzler
Copy link
Contributor Author

alonagetzler commented Aug 23, 2016

we should consider this change as part of the VM Properties refactor #267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant