Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IndicatorHistory API for options indicators in Python #8608

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jhonabreul
Copy link
Collaborator

Description

Fix Python IndicatorHistory API for indicators based on OptionIndicatorBase by fixing the indicator conversion from PyObject.

Also, did the same fix for the WarmUpIndicator API for the same cases, and added missing overloads for warming up multi-symbol indicators both in Python and C#.

Related Issue

Closes #8591

Motivation and Context

Requires Documentation Change

How Has This Been Tested?

Unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • [x ] My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

Fix for indicators based on OptionIndicatorBase to be able to use IndicatorHistory api. They require proper conversion of indicators from PyObjects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OptionIndicators cannot run IndicatorHistory
1 participant