Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed meaning of .+= in Julia 0.5 #132

Closed
stevengj opened this issue Jul 21, 2016 · 1 comment
Closed

Changed meaning of .+= in Julia 0.5 #132

stevengj opened this issue Jul 21, 2016 · 1 comment

Comments

@stevengj
Copy link

Your code uses x .+= y, so you should know that in Julia 0.5 this has changed meaning to be equivalent to broadcast!(identity, x, x .+ y), so that it mutates the x array (see JuliaLang/julia#17510 … in Julia 0.6 the whole operation will occur in-place without temporaries). So .+ should only be used if the left-hand side is a mutable array, and you don't mind mutating it.

At first glance, this seems like a problem for you, because you use y .+= μ / (1 - ρ) where y is a LinSpace object, which is immutable. You can change it to += to avoid trying to mutate y. (However, the code is type-unstable in any case because y changes types, so you might want to use a new variable.)

@sglyon
Copy link
Member

sglyon commented Jul 21, 2016

Thank you for opening this up! We will have to change what we are doing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants