Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit xz and libarchive in dom0 etc due to being released by known-malicious individual #9071

Closed
no-usernames-left opened this issue Mar 30, 2024 · 4 comments
Labels
C: other P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. project management This issue pertains to the management of the Qubes OS Project. security This issue pertains to the security of Qubes OS. T: task Type: task. An action item that is neither a bug nor an enhancement.

Comments

@no-usernames-left
Copy link

no-usernames-left commented Mar 30, 2024

Dom0 has xz-5.4.1, which doesn't include that backdoor. Neither Fedora 39 nor Debian 12 are affected.

Originally posted by @marmarek in #9067 (comment)

xz-5.4.1 was released by the very same person who inserted the backdoor into 5.6.0/5.6.1:
https://github.com/tukaani-project/xz/tree/v5.4.1

We should look at libarchive too; vulnerabilities are now known to have been inserted by the same person who backdoored xz:
libarchive/libarchive#1609

A good timeline is still being created here:
https://boehs.org/node/everything-i-know-about-the-xz-backdoor

We may wish to consider the use of zstd instead:
https://github.com/facebook/zstd

@no-usernames-left no-usernames-left added P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. labels Mar 30, 2024
@no-usernames-left
Copy link
Author

@andrewdavidwong andrewdavidwong added C: other T: task Type: task. An action item that is neither a bug nor an enhancement. security This issue pertains to the security of Qubes OS. project management This issue pertains to the management of the Qubes OS Project. and removed T: bug Type: bug report. A problem or defect resulting in unintended behavior in something that exists. labels Mar 30, 2024
@andrewdavidwong andrewdavidwong changed the title SECURITY: Audit xz and libarchive in dom0 etc due to being released by known-malicious individual Audit xz and libarchive in dom0 etc due to being released by known-malicious individual Mar 30, 2024
@marmarek
Copy link
Member

We are monitoring related information, but for now nobody has found anything nefarious in versions older than 5.6.0 (nor in libarchive). We are not going to audit ourselves all the code he changed, but we may consider some extra mitigation if needed.

@no-usernames-left
Copy link
Author

@marmarek Security of libarchive was downgraded (replacement of safe fprint with unsafe fprint) by the same actor:
libarchive/libarchive#1609

@emaste
Copy link

emaste commented Apr 9, 2024

Note that "released by known-malicious individual" does not apply to libarchive; they were not involved in the libarchive release process and were not a libarchive maintainer.

The known-malicious individual was successful in getting a change into libarchive that is plausibly an intentional, minor security reduction. That is reverted in libarchive 3.7.3. All of their libarchive changes have been re-reviewed (libarchive/libarchive#2103) and no concern was identified with other changes.

That said, additional code review / audit is certainly welcome.

@marmarek marmarek closed this as completed Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: other P: default Priority: default. Default priority for new issues, to be replaced given sufficient information. project management This issue pertains to the management of the Qubes OS Project. security This issue pertains to the security of Qubes OS. T: task Type: task. An action item that is neither a bug nor an enhancement.
Projects
None yet
Development

No branches or pull requests

4 participants