Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

forward/backward search buttons not working in firefox v53 #292

Open
mausalimi opened this issue Jan 28, 2017 · 4 comments
Open

forward/backward search buttons not working in firefox v53 #292

mausalimi opened this issue Jan 28, 2017 · 4 comments

Comments

@mausalimi
Copy link

hello mr. quicksaver.

starting with firefox v53 there's an issue. steps to reproduce:

  • open an empty tab
  • type some text in the find bar
  • load a site where this test actually appears.

now the find bar shows the number of hits. but the forward/backward search buttons are greyed out.
if i press CTRL-F again the buttons do work again.

thanks for developing cool addons in the past.

@vertigo220
Copy link

I've experienced a similar issue, and it occurs pretty regularly. However, for me, sometimes it shows the number of results, and sometimes it shows 0 results even when there are some. It also has nothing to do with starting on a blank page for me; in fact, I don't think I've ever done that. In my case, it seems more related to just switching tabs. I'll do a search on one tab, switch to another and do a search, switch to another and do a search, and after doing this a few times, give or take, it breaks. As mentioned, Ctrl+F fixes it. I'm using Waterfox 56.1.0x64.

@grahamperrin
Copy link

This symptom (forward/backward search buttons not working) is:

From Implementing Content Security Policy - Mozilla Hacks - the Web developer blog (2016-02-16):

The add-ons team recently completed work to enable Content Security Policy (CSP) on addons.mozilla.org (AMO). …

– so I guess that the issue may occur wherever strictness of CSP is in conflict with this feature of FindBar Tweak.

@Imold
Copy link

Imold commented Feb 14, 2019

This symptom (forward/backward search buttons not working) is:

* reproducible at https://addons.mozilla.org/addon/up-to-eleven/

* **not** reproducible at a Wayback Machine capture of the en-US variant of the address, e.g. https://web.archive.org/web/20181020054945/https://addons.mozilla.org/en-US/firefox/addon/up-to-eleven/

From Implementing Content Security Policy - Mozilla Hacks - the Web developer blog (2016-02-16):

The add-ons team recently completed work to enable Content Security Policy (CSP) on addons.mozilla.org (AMO). …

– so I guess that the issue may occur wherever strictness of CSP is in conflict with this feature of FindBar Tweak.

If you set "security.csp.enableStrictDynamic" to false it will work.

@grahamperrin
Copy link

about:config?filter=security.csp.enableStrictDynamic

Great! Thanks @Imold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants