Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird tag encoding issue #33

Closed
atruskie opened this issue Dec 5, 2013 · 3 comments
Closed

Weird tag encoding issue #33

atruskie opened this issue Dec 5, 2013 · 3 comments
Assignees

Comments

@atruskie
Copy link
Member

atruskie commented Dec 5, 2013

image2

@atruskie
Copy link
Member Author

Confirmed - seems a tag with a single quote character triggers some kind of recursive loop. Crashes the tab.

@ghost ghost assigned atruskie Dec 13, 2013
@atruskie
Copy link
Member Author

I've worked this out. Problem line is from angular tags library.

Custom sanitization:
https://github.com/decipherinc/angular-tags/blob/master/src/tags.js#L471

Should probably use ngHtmlBind here:
https://github.com/decipherinc/angular-tags/blob/master/templates/tag.html#L2

Still need to work out why the recursive loop is happening though - the model should not bind back for tag element's it's a oneway binding... that santization function might be changing the model.

@atruskie
Copy link
Member Author

The model is being affected by the sanitization - bad library, bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant