Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do a browser version check on load #99

Closed
atruskie opened this issue Feb 17, 2014 · 1 comment · Fixed by #145
Closed

Do a browser version check on load #99

atruskie opened this issue Feb 17, 2014 · 1 comment · Fixed by #145

Comments

@atruskie
Copy link
Member

Older browsers are definitely not supported in the client. Browser versions should be checked on app load and a warning displayed to users running an outdated browser.

@atruskie
Copy link
Member Author

Jie just reported that IE9 fails to load the annotation editor with no warning (loops back to main project site)

atruskie added a commit that referenced this issue Aug 23, 2014
Browser check occurs once on app load.
If a browser is not supported a warning message is shown.
If it is not well tested and info message is shown.

Of note: two handy module have been incorporated into the solution:
- angular-growl-v2: a notification system we can reuse for other things
- localStorageService: a thing wrapper around the localStorage API.
cofiem added a commit that referenced this issue Aug 25, 2014
feat(browser) Browser check, Closes #99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant