feat(jobs) Custom job ui #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor changes Setup model and dummy service, added in repeater Work on jobs pages Also added scaffolding for side navs Updated dependencies Also fixed failing build, fixed failing unit tests, fixed jshint config and warnings Added missing package
The API changed on the recent major version bump
API changed on recent major version bump
Moved dev server base path to repo base bath so that generated source maps could point to original source files that could be retrieved from the server. Modified build paths to cope with new base. Introduced grunt-newer to speed up builds. Only affected files are processed now. Avg build time (in watch mode) for a single JS file change is down to 5s from 40s.
`container-liquid` was a css class that no longer exists. As a consequence the `row` classes were behaving as if they were `form button.row`s. Resulted in no padding for the page. Updated root layout to use Bootstrap's container-fluid. Also added a tiny bit of margin back into the sections on the visualize page.
The QueryBuilder's toJSON method returned a JSON encoded string - rather than the filtered object it should return. By changing it, the browser's built JSON.stringfy method does the hard work when it serializes the object (because it calls toJSON).
More work on custom jobs UI
- added ace editor dependency for editing configuration blocks - added file size library for friendly byte size formatting - added generalized layout directive for partial style templates outside of local scope hierarchy - work on custom job sui Started scoffolding scripts table COntinued work on new analysis job page Added new library to work with form validation Added angular messages and worked on validation logic Finished validation for current fields on newJob Work on creating new saved searches [WIP]
- add bootstrap customization to change color of input group buttons when validating - fixed bug in `SavedSearch.updateQueryFromBasicFilter` when generating API query - date pickers do not users pick dates outside of the other limits - added a new directive for ensuring textual input for date picker ranges are revalidated each time one of the pair are updated Custom jobs UI - finished new custom job Also added support for generating suggested names for saved searches and analysis jobs
- various other formatting cleanups - added c3 library
Now works with the stricter API introduced in 6eb2e04
Also fixes full page layout bug
- title now works when the current route does not specify a title - 404 page has a title
started on results page. chart building finished.
Initial version of show results page results page coming along Fixed pathing bugs in result view
Now edits original template rather than replacing it - should make it resilient in spite of upgrades.
Pagination href-directive allows us to execute an arbitrary function for generating pagination hyperlinks.
- implement download folder as zip links - implement paging of results
Matches new definition found in angular code base
- changed default target behaviour in breadcrumbs to nothing (open in same frame/window) - made the glyphicon color override more specific - fixed application title bug - removed old function from app.js
I don't know why but bower install seems to just skip installing major versions of dependencies sometimes :-(
atruskie
force-pushed
the
custom-job-ui
branch
from
70b4958 to
095d44b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.