From 598747eea5031f8ff25a8caeeeac9e96df860d20 Mon Sep 17 00:00:00 2001 From: Varixo Date: Fri, 16 Aug 2024 22:48:08 +0200 Subject: [PATCH] fix add event to element returned by signal --- packages/qwik/src/core/v2/shared/component-execution.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/qwik/src/core/v2/shared/component-execution.ts b/packages/qwik/src/core/v2/shared/component-execution.ts index c7ca956b644..3144eba6a7b 100644 --- a/packages/qwik/src/core/v2/shared/component-execution.ts +++ b/packages/qwik/src/core/v2/shared/component-execution.ts @@ -6,7 +6,6 @@ import { JSXNodeImpl, isJSXNode } from '../../render/jsx/jsx-runtime'; import type { JSXNode, JSXOutput } from '../../render/jsx/types/jsx-node'; import type { KnownEventNames } from '../../render/jsx/types/jsx-qwik-events'; import { SubscriptionType } from '../../state/common'; -import { isSignal } from '../../state/signal'; import { invokeApply, newInvokeContext, untrack } from '../../use/use-core'; import { type EventQRL, type UseOnMap } from '../../use/use-on'; import { EMPTY_OBJ } from '../../util/flyweight'; @@ -22,6 +21,7 @@ import { isPromise, maybeThen, safeCall } from '../../util/promises'; import type { ValueOrPromise } from '../../util/types'; import type { Container2, HostElement, fixMeAny } from './types'; import { logWarn } from '../../util/log'; +import { isSignal2 } from '../signal/v2-signal'; /** * Use `executeComponent2` to execute a component. @@ -196,7 +196,7 @@ function findFirstStringJSX(jsx: JSXOutput): ValueOrPromise | nu queue.push(...jsx); } else if (isPromise(jsx)) { return maybeThen | null>(jsx, (jsx) => findFirstStringJSX(jsx)); - } else if (isSignal(jsx)) { + } else if (isSignal2(jsx)) { return findFirstStringJSX(untrack(() => jsx.value as JSXOutput)); } }