[ Bug ] API Request to early/to few retries?

[JanRogge]

Describe the bug
Yesterday while casting i noticed a few failed API request.
While spectating Game One after the Champselect the fetching of live game data failed. This worked fine in the second game.
Meanwhile in the first Game the fetching of match data worked while that failed after the second game.

To Reproduce
I guess its just random API luck.

Expected behavior
The retries wait a bit after a few retries in case of a slow api.

Logs

2023-07-02T17:06:43.780Z [�[32minfo�[39m ] �[95mmodule-league-state�[39m: Flow: lobby - active
2023-07-02T17:08:06.478Z [�[32minfo�[39m ] �[95mmodule-league-state�[39m: Flow: champselect - active
2023-07-02T17:15:44.530Z [�[32minfo�[39m ] �[95mmodule-league-state�[39m: Flow: champselect - game started (spectator delay)
2023-07-02T17:15:44.538Z [�[32minfo�[39m ] �[95mplugin-webapi�[39m: Fetching livegame data for summoner=Player1
2023-07-02T17:15:44.681Z [�[33mwarn�[39m ] �[95mplugin-webapi�[39m: Failed to get spectator game information for summoner=Player1, encryptedId=some-string. Maybe this summoner is not ingame currently? Retrying. error=StatusCodeError: 404 - "{\"status\":{\"message\":\"Data not found\",\"status_code\":404}}"
2023-07-02T17:15:46.681Z [�[31merror�[39m] �[95mplugin-webapi�[39m: Failed to get spectator game information for summoner=Player1, encryptedId=some-string, after retries.
2023-07-02T17:15:46.685Z [�[31merror�[39m] �[95mmodule-league-state�[39m: Loading livegame failed for summoner=Player1
2023-07-02T17:18:46.097Z [�[32minfo�[39m ] �[95mmodule-league-state�[39m: Flow: lobby - inactive
2023-07-02T17:18:46.719Z [�[32minfo�[39m ] �[95mmodule-league-state�[39m: Flow: champselect - inactive
...
2023-07-02T17:40:20.711Z [�[32minfo�[39m ] �[95mplugin-webapi�[39m: Fetching match data for matchid=123412
2023-07-02T17:40:20.992Z [�[32minfo�[39m ] �[95mplugin-webapi�[39m: Fetched match for matchId=123412, gameId=3123123123

2023-07-02T17:48:45.672Z [�[32minfo�[39m ] �[95mmodule-league-state�[39m: Flow: lobby - active
2023-07-02T17:51:39.181Z [�[32minfo�[39m ] �[95mmodule-league-state�[39m: Flow: champselect - active
2023-07-02T17:59:18.698Z [�[32minfo�[39m ] �[95mmodule-league-state�[39m: Flow: champselect - game started (spectator delay)
2023-07-02T17:59:18.706Z [�[32minfo�[39m ] �[95mplugin-webapi�[39m: Fetching livegame data for summoner=Player1
2023-07-02T17:59:18.845Z [�[32minfo�[39m ] �[95mplugin-webapi�[39m: Fetched livegame for summoner=Player1, gameId=2131231
2023-07-02T18:02:19.761Z [�[32minfo�[39m ] �[95mmodule-league-state�[39m: Flow: lobby - inactive
2023-07-02T18:02:20.737Z [�[32minfo�[39m ] �[95mmodule-league-state�[39m: Flow: champselect - inactive
...
2023-07-02T18:33:39.720Z [�[32minfo�[39m ] �[95mplugin-webapi�[39m: Fetching match data for matchid=12312312
2023-07-02T18:33:39.845Z [�[31merror�[39m] �[95mplugin-webapi�[39m: Failed to get match information for matchId=12312312. Maybe the match is not over yet? error=AxiosError: Request failed with status code 404
2023-07-02T18:33:39.847Z [�[31merror�[39m] �[95mmodule-league-state�[39m: Loading match failed for gameId=123123123123

System:

• OS: [e.g. iOS]
• Node: [e.g. 16.4]
• Prod Tool Version: [e.g. 1.3.0]
• Observer Tool Version: [e.g. 1.0.0]
• Streaming Software & Version: (If it is a problem while streaming or testing)
• Browser: [e.g. chrome, safari]

Additional context
Currently i have to watch the server logs so i can manually fetch the data again if it fails which is a bit annoying.
Maybe there should be a bigger delay for retries.

[Himyu]

this issue should be fixed with the newest version of the webapi plugin