Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(electrs): add mempool/electrs support under a new feature #92

Open
oleonardolima opened this issue Feb 4, 2025 · 1 comment
Open

Comments

@oleonardolima
Copy link
Contributor

The crate already has support for blockstream/electrs Esplora API under the feature esplora_a33e97e1, which it's of great use for testing Esplora API, and it's heavily used in rust-esplora-client.

Another implementation of the same API (I'd guess) is developed and maintained by the mempool team, under mempool/electrs.

I think it'd be interesting and a great addition to also have support for it under a new feature, it'd allow to cross-test both APIs and make sure they still align, at least in rust-esplora-client, as the users can choose different implementations to rely on in a non-test scenario, allowing to represent that on the tests.

Any other thoughts about this, any shortcomings I didn't see? Let me know if it'd be a good addition to the crate.

@RCasatta
Copy link
Owner

I guess most of the program arguments are compatible with mempool/electrs, I would accept the changes with a new feature to support it.

It doesn't seem they release official binaries, so a new job in the "build electrs" CI needs to be added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants