Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Instruct Git to not tamper with test data #1848

Closed
aucampia opened this issue Apr 18, 2022 · 2 comments · Fixed by #1981
Closed

Instruct Git to not tamper with test data #1848

aucampia opened this issue Apr 18, 2022 · 2 comments · Fixed by #1981
Assignees
Labels

Comments

@aucampia
Copy link
Member

aucampia commented Apr 18, 2022

Some configurations of Git (e.g. core.autocrlf on windows) will result in Git tampering with test data. Ideally we should configure .gitattributes to treat all data inside test/data as binary and not tamper with it.

I suspect that some of our xfails are related to git tampering with line endings on windows, and if someone is running on WSL2 as they may checkout under windows and then run under linux and our xfails will then not correctly work as they are OS dependent.

A possible instance of this was reported by @edmondchuc while working on WSL2:

https://gitter.im/RDFLib/rdflib?at=625d3540f43b6d783f56b627

FAILED test/test_parsers/test_trig_w3c.py::test_manifest[file:///workspaces/rdflib/test/data/suites/w3c/trig/manifest.ttl#literal_with_LINE_FEED-http://www.w3.org/ns/rdftest#TestTrigEval-rdf_test78] - AssertionError: graphs must be the same, expected
FAILED test/test_parsers/test_trig_w3c.py::test_manifest[file:///workspaces/rdflib/test/data/suites/w3c/trig/manifest.ttl#trig-subm-15-http://www.w3.org/ns/rdftest#TestTrigEval-rdf_test269] - AssertionError: graphs must be the same, expected
FAILED test/test_parsers/test_trig_w3c.py::test_manifest[file:///workspaces/rdflib/test/data/suites/w3c/trig/manifest.ttl#trig-subm-16-http://www.w3.org/ns/rdftest#TestTrigEval-rdf_test270] - AssertionError: graphs must be the same, expected
FAILED test/test_parsers/test_turtle_w3c.py::test_manifest[file:///workspaces/rdflib/test/data/suites/w3c/turtle/manifest.ttl#literal_with_LINE_FEED-http://www.w3.org/ns/rdftest#TestTurtleEval-rdf_test67] - AssertionError: graphs must be the same, expected
FAILED test/test_parsers/test_turtle_w3c.py::test_manifest[file:///workspaces/rdflib/test/data/suites/w3c/turtle/manifest.ttl#turtle-subm-15-http://www.w3.org/ns/rdftest#TestTurtleEval-rdf_test257] - AssertionError: graphs must be the same, expected
FAILED test/test_parsers/test_turtle_w3c.py::test_manifest[file:///workspaces/rdflib/test/data/suites/w3c/turtle/manifest.ttl#turtle-subm-16-http://www.w3.org/ns/rdftest#TestTurtleEval-rdf_test258] - AssertionError: graphs must be the same, expected
@aucampia aucampia changed the title Instruct git to not tamper with test data Instruct Git to not tamper with test data Apr 18, 2022
@aucampia aucampia added the chore label Apr 18, 2022
@aucampia
Copy link
Member Author

aucampia commented Apr 18, 2022

@aucampia aucampia self-assigned this May 29, 2022
@aucampia aucampia linked a pull request Jun 5, 2022 that will close this issue
3 tasks
@aucampia
Copy link
Member Author

aucampia commented Jun 5, 2022

Fixed in #1981

@aucampia aucampia closed this as completed Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant