You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some configurations of Git (e.g. core.autocrlf on windows) will result in Git tampering with test data. Ideally we should configure .gitattributes to treat all data inside test/data as binary and not tamper with it.
I suspect that some of our xfails are related to git tampering with line endings on windows, and if someone is running on WSL2 as they may checkout under windows and then run under linux and our xfails will then not correctly work as they are OS dependent.
A possible instance of this was reported by @edmondchuc while working on WSL2:
FAILED test/test_parsers/test_trig_w3c.py::test_manifest[file:///workspaces/rdflib/test/data/suites/w3c/trig/manifest.ttl#literal_with_LINE_FEED-http://www.w3.org/ns/rdftest#TestTrigEval-rdf_test78] - AssertionError: graphs must be the same, expected
FAILED test/test_parsers/test_trig_w3c.py::test_manifest[file:///workspaces/rdflib/test/data/suites/w3c/trig/manifest.ttl#trig-subm-15-http://www.w3.org/ns/rdftest#TestTrigEval-rdf_test269] - AssertionError: graphs must be the same, expected
FAILED test/test_parsers/test_trig_w3c.py::test_manifest[file:///workspaces/rdflib/test/data/suites/w3c/trig/manifest.ttl#trig-subm-16-http://www.w3.org/ns/rdftest#TestTrigEval-rdf_test270] - AssertionError: graphs must be the same, expected
FAILED test/test_parsers/test_turtle_w3c.py::test_manifest[file:///workspaces/rdflib/test/data/suites/w3c/turtle/manifest.ttl#literal_with_LINE_FEED-http://www.w3.org/ns/rdftest#TestTurtleEval-rdf_test67] - AssertionError: graphs must be the same, expected
FAILED test/test_parsers/test_turtle_w3c.py::test_manifest[file:///workspaces/rdflib/test/data/suites/w3c/turtle/manifest.ttl#turtle-subm-15-http://www.w3.org/ns/rdftest#TestTurtleEval-rdf_test257] - AssertionError: graphs must be the same, expected
FAILED test/test_parsers/test_turtle_w3c.py::test_manifest[file:///workspaces/rdflib/test/data/suites/w3c/turtle/manifest.ttl#turtle-subm-16-http://www.w3.org/ns/rdftest#TestTurtleEval-rdf_test258] - AssertionError: graphs must be the same, expected
The text was updated successfully, but these errors were encountered:
aucampia
changed the title
Instruct git to not tamper with test data
Instruct Git to not tamper with test data
Apr 18, 2022
Some configurations of Git (e.g.
core.autocrlf
on windows) will result in Git tampering with test data. Ideally we should configure.gitattributes
to treat all data insidetest/data
as binary and not tamper with it.I suspect that some of our xfails are related to git tampering with line endings on windows, and if someone is running on WSL2 as they may checkout under windows and then run under linux and our xfails will then not correctly work as they are OS dependent.
A possible instance of this was reported by @edmondchuc while working on WSL2:
https://gitter.im/RDFLib/rdflib?at=625d3540f43b6d783f56b627
The text was updated successfully, but these errors were encountered: