-
Notifications
You must be signed in to change notification settings - Fork 565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rdflib 3.2.2 sparql query broken #234
Comments
You are right - it IS broken, but not that in that commit - it was broken over 2 years ago: r451780760e801d51288d62e131ce70137bd1d086 I'm surprised noone tried to query since then... I will fix and push a 3.2.3 soon |
Hmm - it was broken in 3.2.1 as well - and noone noticed :) |
Hmm - tricker than I thought - in sparql_store I actually use the signature: query(self, graph, query, initNs, initBindings, **kwargs) since you need to know whether the requesting graph is a ConjunctiveGraph (in which case you should query the union of all graphs, depending on the DAWG_COMPLIANCE_FLAG) https://github.com/RDFLib/rdflib/blob/master/rdflib/graph.py#L936 BUT mixing the graph into the store interface and requiring the store implementor to know about conjunctive graphs seems too complicated - so I've added a new queryGraph parameter, see docs in store.query. |
A new 3.2.3 has been release with this fix. |
Thank you, Gunnar. I tested 3.2.3 with our code and now everything is back to normal. Confirming successful resolution of the issue. |
Running this example:
https://github.com/RDFLib/rdflib/blob/master/examples/sparql_query_example.py
under Python 2.7 with rdfextras 0.1 and 0.2 produces:
TypeError: query() takes exactly 4 arguments (5 given)
The text was updated successfully, but these errors were encountered: