Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sample: Allow user to optionally specify serial number and module address #66

Closed
ItsHarper opened this issue May 24, 2023 · 2 comments · Fixed by #69 or #84
Closed

Sample: Allow user to optionally specify serial number and module address #66

ItsHarper opened this issue May 24, 2023 · 2 comments · Fixed by #69 or #84
Assignees
@LandryNorris

Comments

@ItsHarper
Copy link
Contributor

They should be able to specify neither, just one or the other, or both.
@ItsHarper ItsHarper changed the title Allow user to optionally specify serial number and module address Sample: Allow user to optionally specify serial number and module address May 24, 2023
@LandryNorris
Copy link
Contributor

How do we want the syntax of this to look? Right now, the overall structure is sample command subcommand <param1> <param2> [optionalParam3] {flags}, where we cannot have params between command and subcommand. Would flags be helpful here? Perhaps for example sample digital read 1 -s "serial number" -a 2?

@ItsHarper
Copy link
Contributor Author

Yep, flags.

@ItsHarper ItsHarper linked a pull request May 30, 2023 that will close this issue
Allow user to specify serial number and module address of hub #69
Merged
@LandryNorris LandryNorris mentioned this issue Jun 23, 2023
Merged
@LandryNorris LandryNorris mentioned this issue Aug 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LandryNorris LandryNorris

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@ItsHarper @LandryNorris