From eb6c0f6ef404d34c8e9e566375273f6033e44fca Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Mikolai=20G=C3=BCtschow?= <mikolai.guetschow@tu-dresden.de>
Date: Wed, 24 Jan 2024 13:31:54 +0100
Subject: [PATCH] [WIP]: needs cleaner API interface, decision to move away
 from pseudomodule, use conf instead?

---
 sys/malloc_thread_safe/malloc_wrappers.c | 120 ++++++++++++++++++-----
 1 file changed, 97 insertions(+), 23 deletions(-)

diff --git a/sys/malloc_thread_safe/malloc_wrappers.c b/sys/malloc_thread_safe/malloc_wrappers.c
index 487440056f09..f5fc73b274d6 100644
--- a/sys/malloc_thread_safe/malloc_wrappers.c
+++ b/sys/malloc_thread_safe/malloc_wrappers.c
@@ -32,32 +32,100 @@ extern void *__real_realloc(void *ptr, size_t size);
 
 static mutex_t _lock;
 
-void __attribute__((used)) *__wrap_malloc(size_t size)
+#define ALLOC_MAX (100)
+struct {
+    void *addr[ALLOC_MAX];
+    size_t size[ALLOC_MAX];
+    size_t current;
+    size_t all_time_max;
+} malloc_state = {
+    .addr = {NULL},
+    .current = 0,
+    .all_time_max = 0,
+};
+
+void malloc_state_add(void *ptr, size_t size)
 {
-    uinttxtptr_t pc;
-    if (IS_USED(MODULE_MALLOC_TRACING)) {
-        pc = cpu_get_caller_pc();
+    if (ptr == NULL) return;
+    for (uint8_t i=0; i<ALLOC_MAX; i++) {
+        if (malloc_state.addr[i] == NULL) {
+            malloc_state.addr[i] = ptr;
+            malloc_state.size[i] = size;
+            malloc_state.current += size;
+            if (malloc_state.current > malloc_state.all_time_max)
+                malloc_state.all_time_max = malloc_state.current;
+            return;
+        }
     }
+}
+
+void malloc_state_rm(void *ptr)
+{
+    if (ptr == NULL) return;
+    for (uint8_t i=0; i<ALLOC_MAX; i++) {
+        if (malloc_state.addr[i] == ptr) {
+            malloc_state.addr[i] = NULL;
+            malloc_state.current -= malloc_state.size[i];
+            return;
+        }
+    }
+}
+
+void malloc_state_mv(void *ptr_old, void *ptr_new, size_t size_new)
+{
+    if (ptr_old == NULL) return malloc_state_add(ptr_new, size_new);
+    if (size_new == 0) return malloc_state_rm(ptr_old);
+    if (ptr_new == NULL) return;
+    for (uint8_t i=0; i<ALLOC_MAX; i++) {
+        if (malloc_state.addr[i] == ptr_old) {
+            malloc_state.addr[i] = ptr_new;
+            size_t size_old = malloc_state.size[i];
+            malloc_state.size[i] = size_new;
+            if (size_new > size_old) {
+                malloc_state.current += size_new - size_old;
+                if (malloc_state.current > malloc_state.all_time_max)
+                    malloc_state.all_time_max = malloc_state.current;
+            }
+            else {
+                malloc_state.current -= size_old - size_new;
+            }
+            return;
+        }
+    }
+}
+
+void __attribute__((used)) *__wrap_malloc(size_t size)
+{
+    // uinttxtptr_t pc;
+    // if (IS_USED(MODULE_MALLOC_TRACING)) {
+    //     pc = cpu_get_caller_pc();
+    // }
     assert(!irq_is_in());
     mutex_lock(&_lock);
     void *ptr = __real_malloc(size);
-    mutex_unlock(&_lock);
     if (IS_USED(MODULE_MALLOC_TRACING)) {
-        printf("malloc(%" PRIuSIZE ") @ 0x%" PRIxTXTPTR " returned %p\n",
-               size, pc, ptr);
+        malloc_state_add(ptr, size);
     }
+    mutex_unlock(&_lock);
+    // if (IS_USED(MODULE_MALLOC_TRACING)) {
+    //     printf("malloc(%" PRIuSIZE ") @ 0x%" PRIxTXTPTR " returned %p\n",
+    //            size, pc, ptr);
+    // }
     return ptr;
 }
 
 void __attribute__((used)) __wrap_free(void *ptr)
 {
-    if (IS_USED(MODULE_MALLOC_TRACING)) {
-        uinttxtptr_t pc = cpu_get_caller_pc();
-        printf("free(%p) @ 0x%" PRIxTXTPTR ")\n", ptr, pc);
-    }
+    // if (IS_USED(MODULE_MALLOC_TRACING)) {
+    //     uinttxtptr_t pc = cpu_get_caller_pc();
+    //     printf("free(%p) @ 0x%" PRIxTXTPTR ")\n", ptr, pc);
+    // }
     assert(!irq_is_in());
     mutex_lock(&_lock);
     __real_free(ptr);
+    if (IS_USED(MODULE_MALLOC_TRACING)) {
+        malloc_state_rm(ptr);
+    }
     mutex_unlock(&_lock);
 }
 
@@ -81,35 +149,41 @@ void * __attribute__((used)) __wrap_calloc(size_t nmemb, size_t size)
 
     mutex_lock(&_lock);
     void *res = __real_malloc(total_size);
+    if (IS_USED(MODULE_MALLOC_TRACING)) {
+        malloc_state_add(res, total_size);
+    }
     mutex_unlock(&_lock);
     if (res) {
         memset(res, 0, total_size);
     }
 
-    if (IS_USED(MODULE_MALLOC_TRACING)) {
-        printf("calloc(%" PRIuSIZE ", %" PRIuSIZE ") @ 0x%" PRIxTXTPTR " returned %p\n",
-               nmemb, size, pc, res);
-    }
+    // if (IS_USED(MODULE_MALLOC_TRACING)) {
+    //     printf("calloc(%" PRIuSIZE ", %" PRIuSIZE ") @ 0x%" PRIxTXTPTR " returned %p\n",
+    //            nmemb, size, pc, res);
+    // }
 
     return res;
 }
 
 void * __attribute__((used))__wrap_realloc(void *ptr, size_t size)
 {
-    uinttxtptr_t pc;
-    if (IS_USED(MODULE_MALLOC_TRACING)) {
-        pc = cpu_get_caller_pc();
-    }
+    // uinttxtptr_t pc;
+    // if (IS_USED(MODULE_MALLOC_TRACING)) {
+    //     pc = cpu_get_caller_pc();
+    // }
 
     assert(!irq_is_in());
     mutex_lock(&_lock);
     void *new = __real_realloc(ptr, size);
-    mutex_unlock(&_lock);
-
     if (IS_USED(MODULE_MALLOC_TRACING)) {
-        printf("realloc(%p, %" PRIuSIZE ") @0x%" PRIxTXTPTR " returned %p\n",
-               ptr, size, pc, new);
+        malloc_state_mv(ptr, new, size);
     }
+    mutex_unlock(&_lock);
+
+    // if (IS_USED(MODULE_MALLOC_TRACING)) {
+    //     printf("realloc(%p, %" PRIuSIZE ") @0x%" PRIxTXTPTR " returned %p\n",
+    //            ptr, size, pc, new);
+    // }
     return new;
 }