Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

periph/timer: timer_set() underflow safety check (tracking issue) #13072

Open
2 of 5 tasks
kaspar030 opened this issue Jan 10, 2020 · 1 comment
Open
2 of 5 tasks

periph/timer: timer_set() underflow safety check (tracking issue) #13072

kaspar030 opened this issue Jan 10, 2020 · 1 comment
Labels
Area: drivers Area: Device drivers Area: timers Area: timer subsystems Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Type: tracking The issue tracks and organizes the sub-tasks of a larger effort

Comments

@kaspar030
Copy link
Contributor

kaspar030 commented Jan 10, 2020 •
edited by gschorcht
Loading

Description

#13060 added timer_set() protection from IRQ.

There are a couple of other implementations that need to be reviewed for irq safety (found with git grep 'int.*timer_set('):

  • esp32/periph/timer.c (two impls.)
  • esp8266/periph/timer.c (two impls)
  • fe310/periph/timer.c
  • kinetis/periph/timer.c
  • mips32r2_common/periph/timer.c

IMO we should take a close look at all of them. Also, confirm whether they're actually needed or can just be replaced by the generic one.

All four esp implementation seem to internally protect from irqs. @gschorcht maybe confirm?
@kaspar030 kaspar030 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: drivers Area: Device drivers Area: timers Area: timer subsystems Type: tracking The issue tracks and organizes the sub-tasks of a larger effort labels Jan 10, 2020
@gschorcht
Copy link
Contributor

All four esp implementation seem to internally protect from irqs. @gschorcht maybe confirm?

Confirmed 😉

@miri64 miri64 added this to the Release 2020.07 milestone Jul 6, 2020
@MrKevinWeiss MrKevinWeiss removed this from the Release 2021.07 milestone Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: drivers Area: Device drivers Area: timers Area: timer subsystems Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Type: tracking The issue tracks and organizes the sub-tasks of a larger effort
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@miri64 @kaspar030 @MrKevinWeiss @gschorcht