Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"fixup!" tests are ignored. #20287

Closed
chrysn opened this issue Jan 23, 2024 · 0 comments · Fixed by #20288
Closed

"fixup!" tests are ignored. #20287

chrysn opened this issue Jan 23, 2024 · 0 comments · Fixed by #20288
Assignees

Comments

@chrysn
Copy link
Member

chrysn commented Jan 23, 2024

Description

As part of #20286, a "fixup!" commit got merged by the merge queue.

Sorry!

Steps to reproduce the issue

Try merging a fixup commit, I guess -- but it's not like we have a place where we can dry-run this.

Expected results

The check-commits-success check (which did not pass because it depends on check-commits (pr_check)) should have been a critical check and thus prevented merging.

GitHub's settings for the master branch do show chekc-commits-success as required.

Actual results

The commit is now part of our master branch's history.

It's not the first; last time that happened was in 2023-09 (95d1e47).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants