Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language tag not working when followed by a condition function #142

Closed
ritamargherita opened this issue Nov 10, 2021 · 2 comments
Closed

Comments

@ritamargherita
Copy link

Issue type: 🐛 Bug

Description

Following what advised in issue #141, I am not able to add the language tag when there is a condition function after.

The following works and adds correctly the language tag:

mappings:
  cbs:
    sources:
      - ['data.xml~xpath', '/Dataontwerpversies/Versie/Dataontwerp']
    s: cbs:$(Id)
    po:
      - [a, disco:LogicalDataSet]
      - [cbs:dataDesignGroupPath, $(Dataontwerpgroeppad), nl~lang]
      - [cbs:description, $(Beschrijving), nl~lang]
      - [cbs:abbreviatedNameData, $(VerkorteSchrijfwijzeNaamDataontwerp), nl~lang]
      - [cbs:descriptionOfThePopulation, $(BeschrijvingVanDePopulatie), nl~lang]
      - predicates: cbs:methodology
        objects:
            value: $(GebruikteMethodologie)
            language: nl

but when adding a condition function, like below, then it doesn't.

mappings:
  cbs:
    sources:
      - ['data.xml~xpath', '/Dataontwerpversies/Versie/Dataontwerp']
    s: cbs:$(Id)
    po:
      - [a, disco:LogicalDataSet]
      - [cbs:dataDesignGroupPath, $(Dataontwerpgroeppad), nl~lang]
      - [cbs:description, $(Beschrijving), nl~lang]
      - [cbs:abbreviatedNameData, $(VerkorteSchrijfwijzeNaamDataontwerp), nl~lang]
      - [cbs:descriptionOfThePopulation, $(BeschrijvingVanDePopulatie), nl~lang]
      - predicates: cbs:methodology
        objects:
            value: $(GebruikteMethodologie)
            language: nl
        condition:
          function: idlab-fn:notEqual
          parameters:
            - [grel:valueParameter, $(GebruikteMethodologie)]
            - [grel:valueParameter2, ""]

Any thoughts about this behaviour? Or am I adding the language not correctly?

@bjdmeest bjdmeest mentioned this issue Nov 12, 2021
@bjdmeest
Copy link
Collaborator

It seems very much correct, but I see that in the RML mappings, the language tag isn't added, so this seems to be a bug in the YARRRML parser, thanks for finding it! PR #143 is pending to fix this issue! :)

@mvanbrab
Copy link

mvanbrab commented Jun 9, 2022

Shouldn't this issue be closed (+ related issue #141), given release notes of v1.3.3?

@pheyvaer pheyvaer closed this as completed Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants