Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROCM 5.6 release: Incorrect version in hipvars.pm #81

Open
littlewu2508 opened this issue Jul 3, 2023 · 2 comments
Open

ROCM 5.6 release: Incorrect version in hipvars.pm #81

littlewu2508 opened this issue Jul 3, 2023 · 2 comments
Assignees
Labels
generic Build error, or some other issue not caused by an LLVM bug hipcc Related to HIPCC Under Investigation

Comments

@littlewu2508
Copy link

In ROCM 5.6 release, hipvars.pm is still using $HIP_BASE_VERSION_MINOR = "5"; and $HIP_BASE_VERSION_PATCH = "0";

@dgaliffiAMD dgaliffiAMD added the hipcc Related to HIPCC label May 4, 2024
@lamb-j
Copy link
Collaborator

lamb-j commented May 14, 2024

@david-salinas is looking into this, specifically if these macros can be removed so we don't need to worry about them falling out of sync again in the future.

@lamb-j lamb-j transferred this issue from ROCm/HIPCC May 14, 2024
@lamb-j lamb-j assigned lamb-j and david-salinas and unassigned lamb-j May 14, 2024
@ppanchad-amd ppanchad-amd added generic Build error, or some other issue not caused by an LLVM bug Under Investigation labels Jan 7, 2025
@david-salinas
Copy link

A couple of comments to consider for this issue:

  1. we are deprecating the use of Perl in HIPCC, and these Perl files will be removed in an upcoming Release.
  2. There is a C++ version of "hipcc" and "hipconfig" that have a similar issue.
  3. The HIP version information is actually kept in a config file ($HIP_PATH/share/hip/version), that the hipcc/hipconfig tools read. The use of local variables for HIP version are just place holders in case the version file cannot be read.
  4. We are likely not going to make any changes to hipcc in already released Releases, that don't provide technical/funcitonal benefit

We can clean up the C++ hipcc/hipconfig tools so that we no longer have to manually update local variable place holder version numbers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
generic Build error, or some other issue not caused by an LLVM bug hipcc Related to HIPCC Under Investigation
Projects
None yet
Development

No branches or pull requests

5 participants