Ref #2894 fixing segmentation fault for doc2vec #2902
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any instructions on what I can do to resolve these circle ci failures? |
|
Your modified file doesn't even compile, see the log. You cannot change the types that mechanically, the signatures and data structures need to match. If you're not familiar with C code it's probably best to wait until we get to it. Although I cannot promise any ETA, we're busy with preparing for 4.0.0 now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #2894 I was unable to install
testscripts (pip install -e .[test]) and could not test it on my PC. Please review the PR and let me know if I need to change something before its gets meged.Also I see some other potential script that could have the same problem, for example word2vec_corpusfile.pyx