Add version_id transport parameter for fetching a specific S3 object version #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added check for the existence of the passed id.
mpenkov
requested changes
Jun 16, 2019
smart_open/s3.py
Outdated
| @@ -112,6 +114,7 @@ def open( | |||
| fileobj = SeekableBufferedInputBase( | |||
| bucket_id, | |||
| key_id, | |||
| version_id, | |||
There was a problem hiding this comment.
Pass keyword parameters by name.
Suggested change
| version_id, | |
| version_id=version_id, |
1. Updated help revision_id; 2. Added version validation when getting the length of an object s3 in BufferedInputBase; 3. Style adjustment.
mpenkov
requested changes
Jun 17, 2019
….ClientError - creates an exception IOerror
added 5 commits
June 22, 2019 13:50
This test checks the correctness of reading object s3 by version and calling an exception if the object version is incorrect.
mpenkov
requested changes
Jun 23, 2019
mpenkov
requested changes
Jun 26, 2019
There was a problem hiding this comment.
Let you some more comments.
Also, you're missing a top-level test. You should make sure that working with your version_id parameter via the top-level smart_open.open function works as intended.
Finally, it looks like the documentation isn't picking up your new parameter. It should appear here but does not.
|
Also, looks like unit tests are failing, please fix: |
… the version is not None. Added test for this.
piskvorky
requested changes
Jun 26, 2019
mpenkov
reviewed
Jun 28, 2019
added 3 commits
July 4, 2019 21:43
# Conflicts: # smart_open/tests/test_s3_version.py
piskvorky
requested changes
Jul 7, 2019
- changed the name of the object in the use case version_id; - pep8
mpenkov
reviewed
Jul 9, 2019
piskvorky
requested changes
Jul 14, 2019
mpenkov
changed the title
mpenkov
approved these changes
Jul 15, 2019
|
@interpolatio Congrats on your very first contribution to smart_open! 🥇 Keep them coming! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added file check by id.
Added check for the existence of the passed id.
Fix #306