Fix to_boto3 method #619
Merged
Fix to_boto3 method #619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method had a bug where it was always creating its own boto3 resource. The intention was that it re-used the resource held by the class containing the method. However, we've since moved away from the resource API, because it is not multiprocessing-friendly. So, the contained class no longer holds a boto3 resource. We now require to_boto3 to receive the resource as a parameter. This achieves a trade-off between convenience and thread safety: - The user can use the more convenient Resource API - The smart_open library does not have to create unsafe objects by itself (the user does that) Fix #615
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method had a bug where it was always creating its own boto3
resource. The intention was that it re-used the resource held by the
class containing the method.
However, we've since moved away from the resource API, because it is not
multiprocessing-friendly. So, the contained class no longer holds a
boto3 resource. We now require to_boto3 to receive the resource as a
parameter. This achieves a trade-off between convenience and thread
safety:
itself (the user does that)
Fix #615