Improve S3 URI Parsing for URIs with "@", "/", and ":" #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
mpenkov
approved these changes
Sep 6, 2023
|
OK, I've clarified the code a bit and merged your changes. Thank you @rileypeterson ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve S3 URI Parsing for URIs with "@", "/", and ":"
Motivation
I am improving an old PR of mine from a long time ago and addressing a recent comment:
#235
#235 (comment)
Original Issue: #234
Tests
I wrote two unit tests which pass and no regressions.
Checklist
Before you create the PR, please make sure you have: