Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recommended changes resulting from automated audit #16

Closed
5 tasks
Jericho opened this issue Jun 5, 2018 · 2 comments · May be fixed by #17
Closed
5 tasks

Recommended changes resulting from automated audit #16

Jericho opened this issue Jun 5, 2018 · 2 comments · May be fixed by #17

Comments

@Jericho
Copy link

Jericho commented Jun 5, 2018 •
edited
Loading

We performed an automated audit of your Cake addin and found that it does not follow all the best practices.

We encourage you to make the following modifications:

  • You are currently referencing Cake.Core 0.23.0. Please upgrade to 0.28.0
  • You are currently referencing Cake.Common 0.23.0. Please upgrade to 0.28.0
  • The Cake.Core reference should be private. Specifically, your addin's .csproj should have a line similar to this: <PackageReference Include="Cake.Core" Version="0.28.0" PrivateAssets="All" />
  • The Cake.Common reference should be private. Specifically, your addin's .csproj should have a line similar to this: <PackageReference Include="Cake.Common" Version="0.28.0" PrivateAssets="All" />
  • Your addin should target netstandard2.0. Please note that there is no need to multi-target, netstandard2.0 is sufficient.

Apologies if this is already being worked on, or if there are existing open issues, this issue was created based on what is currently published for this package on NuGet.org and in the project on github.
@Jericho
Copy link
Author

Jericho commented Apr 20, 2019

We performed a follow up automated audit of your Cake addin and found that some (or all) issues previously identified have not been resolved.

We strongly encourage you to make the modifications previously highlighted.

Apologies if this is already being worked on, or if there are existing open issues, this issue was created based on what is currently published for this package on NuGet.

This comment was created by a tool: Cake.AddinDiscoverer version 3.12.1

Jericho added a commit to Jericho/Cake.Talend that referenced this issue Apr 30, 2019
@Jericho
(RadioSystemsGH-16) Fix iconUrl
6f4c22a
@Jericho Jericho mentioned this issue Apr 30, 2019
Open
@augustoproiete
Copy link

@Jericho as you know, this addin is now maintained on https://github.com/cake-contrib/Cake.Talend and this can be closed (will be done as part of the updating the addin for Cake v1.0 compat)

@Jericho Jericho closed this as not planned Won't fix, can't repro, duplicate, stale Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issues identified by automated audit Jericho/Cake.Talend
2 participants
@Jericho @augustoproiete