Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code: Refactor too long functions #1794

Open
nirs opened this issue Feb 2, 2025 · 0 comments
Open

code: Refactor too long functions #1794

nirs opened this issue Feb 2, 2025 · 0 comments

Comments

@nirs
Copy link
Member

nirs commented Feb 2, 2025

We have 39 functions using //nolint:funlen to allow longer function. This typically means that the function need refactoring to make it shorter and simpler. Real case when longer functions are needed are very rare.

We need to review the functions and improve them.

% git grep -E 'nolint:.*funlen'
e2e/deployers/crud.go:// nolint:funlen
e2e/dractions/actions.go:// nolint:funlen
e2e/dractions/discovered.go:// nolint:funlen,cyclop
internal/controller/cephfscg/cghandler.go://nolint:funlen,gocognit,cyclop,gocyclo
internal/controller/cephfscg/replicationgroupdestination.go://nolint:cyclop,funlen
internal/controller/cephfscg/replicationgroupsource.go://nolint:funlen
internal/controller/cephfscg/volumegroupsourcehandler.go://nolint:funlen
internal/controller/cephfscg/volumegroupsourcehandler.go://nolint:funlen,cyclop
internal/controller/cephfscg/volumegroupsourcehandler.go://nolint:funlen,gocognit,cyclop
internal/controller/cephfscg/volumegroupsourcehandler.go://nolint:funlen
internal/controller/drplacementcontrol.go://nolint:funlen
internal/controller/drplacementcontrol.go://nolint:gocognit,cyclop,funlen
internal/controller/drplacementcontrol_controller.go://nolint:funlen
internal/controller/drplacementcontrol_controller.go://nolint:funlen,gocognit,gocyclo,cyclop
internal/controller/drplacementcontrol_controller.go://nolint:funlen
internal/controller/drplacementcontrol_controller.go://nolint:funlen,cyclop
internal/controller/drplacementcontrol_controller.go://nolint:funlen
internal/controller/drplacementcontrol_controller.go://nolint:funlen,nestif,gocognit,gocyclo,cyclop
internal/controller/drplacementcontrol_controller_test.go://nolint:funlen
internal/controller/drplacementcontrol_watcher.go://nolint:funlen
internal/controller/drpolicy_controller.go://nolint:cyclop,funlen
internal/controller/replicationgroupsource_controller.go://nolint:funlen
internal/controller/volsync/vshandler.go://nolint:cyclop,funlen
internal/controller/volsync/vshandler.go://nolint:funlen
internal/controller/volsync/vshandler.go://nolint:cyclop,funlen,gocognit
internal/controller/volsync/vshandler.go://nolint:funlen,gocognit,cyclop
internal/controller/volsync/vshandler.go://nolint:funlen
internal/controller/volsync/vshandler.go://nolint:funlen
internal/controller/volsync/vshandler_test.go://nolint:funlen
internal/controller/volumereplicationgroup_controller.go://nolint:funlen
internal/controller/vrg_volrep.go://nolint:gocognit,cyclop,funlen
internal/controller/vrg_volrep.go://nolint:funlen,cyclop,gocognit
internal/controller/vrg_volrep.go://nolint:funlen
internal/controller/vrg_volrep.go://nolint:funlen,gocognit,cyclop
internal/controller/vrg_volsync.go://nolint:gocognit,funlen,cyclop
internal/controller/vrg_volsync.go://nolint:gocognit,funlen,cyclop,gocyclo,nestif
internal/controller/vrg_volsync.go://nolint:gocognit,funlen,cyclop,nestif
internal/controller/vrg_volsync.go://nolint:gocognit,funlen,cyclop
internal/controller/vrg_volsync_test.go://nolint:funlen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant