Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APKMirror downloader #12

Closed
ghost opened this issue Jun 28, 2022 · 24 comments
Closed

APKMirror downloader #12

ghost opened this issue Jun 28, 2022 · 24 comments

Comments

@ghost
Copy link

ghost commented Jun 28, 2022

I am unfamiliar with kotlin, so I ask if it is possible to implement this feature (as I have already done on my personal patcher).

It is very convenient and saves a lot of time.

@oSumAtrIX
Copy link
Member

APKMirror is a third-party service, the manager should not rely on it.

@rushiiMachine
Copy link

APKMirror is still Cloudflare protected, making it impossible to scrape without doing background webview trickery like tachiyomi does.

@oSumAtrIX
Copy link
Member

CF clearance check can be bypassed in a different way.

@ghost
Copy link
Author

ghost commented Jun 28, 2022

APKMirror is still Cloudflare protected, making it impossible to scrape without doing background webview trickery like tachiyomi does.

Is not much difficult to fetch the last version (and generate the download link from it).

I can eventually make my code open source, but this depends on the team's decision.

@oSumAtrIX
Copy link
Member

You should decide that independent of the team's decision.

@ghost
Copy link
Author

ghost commented Jun 28, 2022

CF clearance check can be bypassed in a different way.

There's nothing to bypass honestly. It's all available on the "pre-download page" of the specific package.

@alexandreteles
Copy link

If we're going to download the APK/OBB files I see no reason why we shouldn't do it directly from the Play Store. Besides cases where access to the Play Store is blocked somehow, unlikely as that may be, we should avoid using mirrors that can be compromised and inject malicious code in whatever is being downloaded.

In my humble opinion, if this functionality gets added to the software it should be accompanied of a small security warning and be tied to an opt-in.

@bogadana
Copy link

bogadana commented Jul 4, 2022

can be compromised and inject malicious code in whatever is being downloaded.

apks have signatures

@ghost
Copy link
Author

ghost commented Jul 4, 2022

If we're going to download the APK/OBB files I see no reason why we shouldn't do it directly from the Play Store. Besides cases where access to the Play Store is blocked somehow, unlikely as that may be, we should avoid using mirrors that can be compromised and inject malicious code in whatever is being downloaded.

In my humble opinion, if this functionality gets added to the software it should be accompanied of a small security warning and be tied to an opt-in.

Except from the fact that old Vanced has always been based on apkmirror apks (and no one has ever complained about it), I think it is quite complicated to modify an apk while leaving the signature unchanged.

I don't think it is even possible to do so at present.

@oSumAtrIX
Copy link
Member

APKMirror is a dependency we should not have to rely on to begin with, it should be the users job to prepare the application they want to patch. It might be an application which is only available in the playstore. An apk downloader feature is too out of scope for this purpose.

@Degl1
Copy link

Degl1 commented Jul 4, 2022

At best there should be an option to extract the apk from the installed app.

@budchirp
Copy link

budchirp commented Jul 4, 2022

At best there should be an option to extract the apk from the installed app.

Manager have that

@ghost
Copy link
Author

ghost commented Jul 4, 2022

At best there should be an option to extract the apk from the installed app.

Bleah...

Keep the original app installed is like drinking gasoline.

@alexandreteles
Copy link

At best there should be an option to extract the apk from the installed app.

Bleah...

Keep the original app installed is like drinking gasoline.

Unless we consistently support casting on ReVanced keeping the original app does have an important purpose for many people.

@SubZero5
Copy link

SubZero5 commented Jul 5, 2022

Why not get APK's from goog.l directly?

@TheJeterLP
Copy link

Why not get APK's from goog.l directly?

Because google does not supply APKs.

@alexandreteles
Copy link

Why not get APK's from goog.l directly?

Because google does not supply APKs.

It is possible to obtain APK/OBB data directly from Google Play programmatically using Aurora's gplayapi (https://gitlab.com/AuroraOSS/gplayapi). I'm not sure how hard would it be to integrate it with the manager but obtaining data directly from the Play Store is probable the best way to proceed in this case. There are other tools that could allow us to do the same (ex.: https://github.com/ClaudiuGeorgiu/PlaystoreDownloader) but it would require a different infrastructure and more careful consideration.

@ghost
Copy link
Author

ghost commented Jul 5, 2022

Why not get APK's from goog.l directly?

Because google does not supply APKs.

It is possible to obtain APK/OBB data directly from Google Play programmatically using Aurora's gplayapi (https://gitlab.com/AuroraOSS/gplayapi). I'm not sure how hard would it be to integrate it with the manager but obtaining data directly from the Play Store is probable the best way to proceed in this case. There are other tools that could allow us to do the same (ex.: https://github.com/ClaudiuGeorgiu/PlaystoreDownloader) but it would require a different infrastructure and more careful consideration.

If somebody is able to do it...it would be the best solution.

@TheJeterLP
Copy link

In my opinion we should not download an apk from google to modify it. This could have consequences by Google. It is the users job to get a suiting APK.

@TheJeterLP TheJeterLP closed this as not planned Won't fix, can't repro, duplicate, stale Jul 5, 2022
@CookieXD
Copy link

Why not just upload the used APK files somewhere (for example a private google drive folder) and let the manager always download these from (for example a specified google drive folder.) there.

@alexandreteles
Copy link

Why not just upload the used APK files somewhere

Because redistributing proprietary software is a no-no.

@rollingmoai
Copy link

rollingmoai commented Sep 15, 2022

So, any solution to this?

@rollingmoai
Copy link

Something like Aliucord can download the corresponding Discord APK though, can't Revanced do the same?

@indrastorms
Copy link

What's about hosting the original apk on a separate github repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests