-
-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APKMirror downloader #12
Comments
APKMirror is a third-party service, the manager should not rely on it. |
APKMirror is still Cloudflare protected, making it impossible to scrape without doing background webview trickery like tachiyomi does. |
CF clearance check can be bypassed in a different way. |
Is not much difficult to fetch the last version (and generate the download link from it). I can eventually make my code open source, but this depends on the team's decision. |
You should decide that independent of the team's decision. |
There's nothing to bypass honestly. It's all available on the "pre-download page" of the specific package. |
If we're going to download the APK/OBB files I see no reason why we shouldn't do it directly from the Play Store. Besides cases where access to the Play Store is blocked somehow, unlikely as that may be, we should avoid using mirrors that can be compromised and inject malicious code in whatever is being downloaded. In my humble opinion, if this functionality gets added to the software it should be accompanied of a small security warning and be tied to an opt-in. |
apks have signatures |
Except from the fact that old Vanced has always been based on apkmirror apks (and no one has ever complained about it), I think it is quite complicated to modify an apk while leaving the signature unchanged. I don't think it is even possible to do so at present. |
APKMirror is a dependency we should not have to rely on to begin with, it should be the users job to prepare the application they want to patch. It might be an application which is only available in the playstore. An apk downloader feature is too out of scope for this purpose. |
At best there should be an option to extract the apk from the installed app. |
Manager have that |
Bleah... Keep the original app installed is like drinking gasoline. |
Unless we consistently support casting on ReVanced keeping the original app does have an important purpose for many people. |
Why not get APK's from |
Because google does not supply APKs. |
It is possible to obtain APK/OBB data directly from Google Play programmatically using Aurora's |
If somebody is able to do it...it would be the best solution. |
In my opinion we should not download an apk from google to modify it. This could have consequences by Google. It is the users job to get a suiting APK. |
Why not just upload the used APK files somewhere (for example a private google drive folder) and let the manager always download these from (for example a specified google drive folder.) there. |
Because redistributing proprietary software is a no-no. |
So, any solution to this? |
Something like Aliucord can download the corresponding Discord APK though, can't Revanced do the same? |
What's about hosting the original apk on a separate github repo? |
I am unfamiliar with kotlin, so I ask if it is possible to implement this feature (as I have already done on my personal patcher).
It is very convenient and saves a lot of time.
The text was updated successfully, but these errors were encountered: