-
-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Don't show "Disable auto updates" warning every time #1628
Comments
Edit: turns out I've not actually run a patch on 1.18.0 that's why I've not encountered this....
|
Yes, non-rooted users are significant. Your device may attempt to update the patched app by matching the package name of the patched app to a database. The warning should not be shown once; otherwise you'll forget it. At max, it can be a popup with a checkmark to not show again. |
But isn't the package name changed by default for non-rooted users due to the GMS Core patch? Edit: Yes, there are other apps which doesn't have a changed package name and for those it's significant. But, if that's the case then it should be made per app basis or dependent to the patches selected. Given if microg or gms core patches are selected then there's no significance to this warning. |
ReVanced Manager isn't aware of whether or not the new package name exists as an entry in the PlayStore |
I can agree with this as a solution. The user can agree to the statement and produce a pop-up saying never to show again after agreeing. |
Bug description
When the user updates the app via revanced manager, even if they have done it before, they are still shown a warning screen saying to disable auto updates. I understand that this is significant for rooted users as the play store will try to update YouTube if it's not disabled. But is there any significance for this warning to be shown to non-rooted users? And if there is, I believe that it should only be shown once and once the user accepts the warning, it should not be shown to the user everytime they try to patch an app.
The warning message:

Version of ReVanced Manager and version & name of application you tried to patch
ReVanced Manager 1.18.0
Installation type
Non-root
Device logs
Patcher logs
No response
Acknowledgements
The text was updated successfully, but these errors were encountered: