Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Don't show "Disable auto updates" warning every time #1628

Open
4 tasks done
ILoveOpenSourceApplications opened this issue Jan 9, 2024 · 6 comments
Open
4 tasks done
Labels
Feature request Requesting a new feature that's not implemented yet

Comments

@ILoveOpenSourceApplications

Bug description

When the user updates the app via revanced manager, even if they have done it before, they are still shown a warning screen saying to disable auto updates. I understand that this is significant for rooted users as the play store will try to update YouTube if it's not disabled. But is there any significance for this warning to be shown to non-rooted users? And if there is, I believe that it should only be shown once and once the user accepts the warning, it should not be shown to the user everytime they try to patch an app.

The warning message:
Screenshot_20240109_151119_ReVanced Manager

Version of ReVanced Manager and version & name of application you tried to patch

ReVanced Manager 1.18.0

Installation type

Non-root

Device logs

Nil

Patcher logs

No response

Acknowledgements

  • This request is not a duplicate of an existing issue.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
  • The issue is solely related to the ReVanced Manager
@ILoveOpenSourceApplications ILoveOpenSourceApplications added the Bug report Something isn't working label Jan 9, 2024
@GlitchyPie
Copy link

GlitchyPie commented Jan 13, 2024

Edit: turns out I've not actually run a patch on 1.18.0 that's why I've not encountered this....

I've never seen this warning, what are the conditions required for it to even show in the first place.

Also on 1.18.0

Non-root user.

@oSumAtrIX
Copy link
Member

Yes, non-rooted users are significant. Your device may attempt to update the patched app by matching the package name of the patched app to a database. The warning should not be shown once; otherwise you'll forget it. At max, it can be a popup with a checkmark to not show again.

@ILoveOpenSourceApplications
Copy link
Author

ILoveOpenSourceApplications commented Jan 13, 2024

But isn't the package name changed by default for non-rooted users due to the GMS Core patch?

Edit: Yes, there are other apps which doesn't have a changed package name and for those it's significant. But, if that's the case then it should be made per app basis or dependent to the patches selected. Given if microg or gms core patches are selected then there's no significance to this warning.

@Ushie
Copy link
Member

Ushie commented Jan 13, 2024

ReVanced Manager isn't aware of whether or not the new package name exists as an entry in the PlayStore

@ILoveOpenSourceApplications
Copy link
Author

At max, it can be a popup with a checkmark to not show again.

I can agree with this as a solution. The user can agree to the statement and produce a pop-up saying never to show again after agreeing.

@Qaz-6

This comment was marked as spam.

@oSumAtrIX oSumAtrIX added Feature request Requesting a new feature that's not implemented yet and removed Bug report Something isn't working labels Jun 13, 2024
@oSumAtrIX oSumAtrIX changed the title bug: Warning being shown everytime feat: Don't show "Disable auto updates" warning every time Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request Requesting a new feature that's not implemented yet
Projects
None yet
Development

No branches or pull requests

6 participants