Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info-cards (not endcards) are hidden all the time #2057

Closed
3 tasks done
Hokyps opened this issue Sep 25, 2022 · 4 comments
Closed
3 tasks done

Info-cards (not endcards) are hidden all the time #2057

Hokyps opened this issue Sep 25, 2022 · 4 comments
Labels
Bug report Something isn't working

Comments

@Hokyps
Copy link

Hokyps commented Sep 25, 2022

Type

Cosmetic

Bug description

It doesn't matter if I turn on or off the toggle "Show-infocards" they aren't visible anyways.

Steps to reproduce

Just try playing any video with info-cards like this one: https://youtu.be/qiVqicC8sIA

Relevant log output

Don't know how to get one.

Screenshots or videos

Screenshot_20220924-173935_YouTube

Screenshot_20220924-174309_YouTube

Screenshot_20220924-175709

Solution

Excluding the patch "Hide infocards suggestions" while building the apk fixes the problem.

Additional context

Build my Revanced with Revanced builder.
Youtube version: 17.36.37
Cli: 2.11.2
Patches: 2.69.1
Integrations: 0.42.2

Acknowledgements

  • I have searched the existing issues and this is a new and no duplicate or related to another open issue.
  • I have written a short but informative title.
  • I filled out all of the requested information in this issue properly.
@Hokyps Hokyps added the Bug report Something isn't working label Sep 25, 2022
@SodaWithoutSparkles
Copy link
Contributor

can reproduce the issue. Did the maintainer of the patch forgot something?

@furquim87
Copy link

furquim87 commented Nov 4, 2022

I'm getting a similar issue as well, although a bit different: the info cards do show up here, but they disappear a split second after showing up. They also seem to have a problem with full screen panels, as they won't show whenever I enable them, unless I enter full screen mode, open one of the panels and close it. I'm using j-hc build, but the same issue happens when building via the official ReVanced Manager.

@Hokyps
Copy link
Author

Hokyps commented Nov 6, 2022

I'm getting a similar issue as well, although a bit different: the info cards do show up here, but they disappear a split second after showing up. They also seem to have a problem with full screen panels, as they won't show whenever I enable them, unless I enter full screen mode, open one of the panels and close it. I'm using j-hc build, but the same issue happens when building via the official ReVanced Manager.

You could try patching the app again without including the infocard patch.

@johnconner122
Copy link
Contributor

Please close the issue if fixed.

@revanced-bot revanced-bot transferred this issue from ReVanced/revanced-patches-template Dec 14, 2023
@oSumAtrIX oSumAtrIX transferred this issue from another repository Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants