-
-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug: Videos not loading #2483
Comments
Please attach a recording. |
Attached video. XRecorder_05112022_143328.1.mp4 |
Can you record if this happens on multiple videos? |
Happens 4 times on the attached clip. Also on the 3rd one it happens on, you can see something strange (around 1m53s). It looks like it rewinds, even though i wasn't touching the screen at the time. (never seen it do that before, hence why i am mentioning it). XRecorder_05112022_145644.0.mp4 |
I can not reproduce this on my end on an account where this issue is present without applying the fix. To reproduce I would need access to the account to test the issue on. |
Seems like commit e756fac failed. After a fix and a release for it, the issue should be solved |
With patches v2.104.0 it has massively improved, thank you. But not totally fixed. It still happens occasionally, but only on the first video played after Revanced is opened. |
Problem persists in exactly same modalities here, with the only exception that in my case it happens in all the videos: played and previewed. My workaround is being connected to a VPN (nordvpn) pointing outside the UK, for example Paris or Milan. LineageOS 18.1 (Android 11) |
I'm experiencing this problem as well in the Netherlands. As of today. |
Changes are rolled out to multiple countries. |
Try going into ReVanced settings and turning off all switches (including hide advertising). Then ReVanced should behave exactly the same as stock YouTube (including showing ads). After doing this, is the issue still present? |
This is not a ReVanced specific issue. Any client mod will cause this issue. This does not happen on mounted variant. Signature or package name is checked and server returns 403 on /videoplayback. The check can be outside of the app itself in GMS for example (or in non root variant in MicroG) or inside the app. I already spoofed every getPackageInfo call in YouTube but that did not help either, it is known that there is other ways to get the signature or package name (for example via context.getPackageName which i havent tried spoofing yet), or it was done in GMS/MicroG (which I havent looked into much either). In any case, this issue can be fixed by spoofing the signature and package name at some place properly. |
Would be useful if someone with the issue tried using a root installation of ReVanced, and confirmed the issue is not present. |
@LisoUseInAIKyrios I am able to reproduce in my dev env and can confirm that the root variant does not have this issue, hence why my conclusions on signature and package name. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This issue is related to microg and not related to ReVanced YouTube. So closing this as of now. |
as a work around try disabling Push nofications and cloud messaging it seems like there is some kind of timeout on whatever restiction they are using when vanced is detected as well switching accounts and using the other account for awhile seems to unrestrict the other account allowing video to play |
Would it be easy to create a patch that detects the condition (detect 403 status code)? And then show the user a dialog that informs them what is going on, and give suggestions on how to fix (use incognito mode, change YouTube accounts, use VPN, install root ReVanced, etc)? It would go a long way to help users figure out what to do. |
An exception is thrown at a certain place, so yeah, it's feasible |
Type
Error at runtime
Bug description
The same as #2484 but i cannot reopen that one.
The fix put in for #2484 seems to have helped a lot, but the issue still happens just less frequently.
After watching a few videos, it then gets stuck loading the video indefinitely.
You can work around this buy skipping to the end of the video then using replay to restart playback.
Steps to reproduce
Relevant log output
Screenshots or videos
No response
Solution
You can work around this buy skipping to the end of the video then using replay to restart playback.
Additional context
Not sure if it is related, but occasionally after using the skip to the end work around, the video will display the loading circle all the way through the video (while still playing).
This happening with the setting in "ReVanced -> Miscellaneous -> Fix video playback issues" enabled.
I tried updating to YouTube 17.43.36 but the issue persists.
Versions:
Android 8
Patched YouTube 17.43.36
Revanced Manager 0.0.39
Revanced Patches 2.102.1
Vanced microG 0.2.24.220220
Patches installed:
Custom Branding
General Ads
MicroG Support
Minimized Playback
Theme
Video Ads
This issue is assumed to be caused by MicroG: microg/GmsCore#1870.
Acknowledgements
The text was updated successfully, but these errors were encountered: