-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(YouTube - Remember video quality): Not restoring remembered quality #2675
Comments
I cannot reproduce the issue. Setting 1440p works correctly and uses the highest resolution up to 1440p. It can take a few seconds for the UI quality picker to show the ReVanced default is set. Many people have previously complained it's not applying the Revanced default, and it turned out they were opening the UI picker immediately after a video opened and all they needed to do was wait 5-10 seconds for the quality default to actually apply. If it's never applying the highest resolution available, then it's possible YT is ignoring the initial patched call to change the quality. You can try selecting 'higher picture quality' in the YT 'video quality preference' and maybe that will help. And you can try version spoofing (under ReVanced -> Layout) to |
I am reproducing this. I set the default to 4k, then start a video which is 720p at max. After some time YT defaults to 480p. |
It's possible that on video load, the qualities are not available, and the patch attempting to set them is ignored by YouTube which then defaults to some other quality |
A solution would involve hooking the method which is called when the qualities are loaded. At that point the patch could set the quality, if thats actually the problem |
Or maybe YT is changing the video quality during playback. The remember quality patch only sets the quality once on video load. Does spoofing to 18.20.39 or lower behave the same? |
As far as I know we hook the set quality method. We intercept the quality parameter through the patch, then call the video.setQuality method. We could find references to it and check if its being called.or hook that method |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
I experience this bug aswell. However, a method that helped me somewhat mitigate the issue, is to spoof player dimensions. It helps picking the higher quality (1440p and up) more consistently. |
To anyone with this issue, try turning on version spoofing (under And maybe or maybe not it will help. |
Thanks, this is working. I spoof it to 18.20.39 |
Try manually setting the spoof target to To manually change the spoof target, go to And change it to: Press the import button and restart the app. Then report back if the default video quality is still fixed |
So after i switched it to 18.38.45 I experience something different. It starts at 720p60 and then go's to 1080p60. It will stay on 1080p60 for awhile and then switch to 1440p60 but sometimes it stays on 1080p60. This only happens on videos that is 60fps. And on other videos it will start at 1440p that are not 60fps. So does the 60fps part make a difference? Can someone else also confirm this please. |
I can't confirm because I don't have the quality issue. But if it's acting worse or inconsistent, then keep using |
Ok. I understand. And yes, I did set it back to 18.20.39 and it works perfectly thanks. |
Looks like its the usual delay that occurs when starting videos. After some seconds it goes to the highest available quality. |
It does it on the first video, but if the first video highest quality is, for example, 1080p, after switching to higher quality video, the quality will remain 1080p |
This comment was marked as spam.
This comment was marked as spam.
Hello. This issue happening in 1080p and 720p as well. Youtube makes it 480p and does not restore after and it happens on every single video. What happens is video loads in remembered quality but falls back to 480p after a few seconds. |
Yea its still happening. I just ignored it and choose the quality everytime myself. It has been an issue for a long time. But try the solution. See if it works for you. Spoof the app version to 18.20.39 |
Tried spoofing into 18.20.39, it looks stable. Video starts from 720p but changes back to prefered resolution after a few seconds. |
This comment was marked as duplicate.
This comment was marked as duplicate.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
RVX dev has found a solution to this without spoofing the app version. I hope it can be implemented in Revanced aswell. |
Please share the solution of RVX. |
RVX dev fixed it. I guess you will need to use RVX and patch YouTube with rvx patches. I don't why Revanced Dev don't implement it here to |
Link the commit/fix |
|
That does not fix the issue but work around it & causes stutter in the beginning of the video |
I think this issue was fixed with #3879 |
Yep, it will match the probable cause I am suspecting. Not tested yet. |
I viewed multiple times the quality, but after this patch Revanced always apply the selected quality or the highest available quality. |
It has been fixed. Thank you. Its working again. |
Bug description
Hello, after patching the new recommend version of YT with the latest patches the remember video quality patch doesn't work properly anymore.
1440p is my default quality preference I selected. And when it's not available on a video it chooses 1080p. But now if 1440p is not available it doesn't select the available highest video quality. It selects 360 or 480p.
Solution
Enable version spoofing (under
ReVanced Settings -> General layout
) and use spoof target18.20.39
Acknowledgements
The text was updated successfully, but these errors were encountered: