Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(YouTube - Remember video quality): Not restoring remembered quality #2675

Closed
3 tasks done
CoolCooler0 opened this issue Jan 30, 2024 · 37 comments · Fixed by #3879
Closed
3 tasks done

bug(YouTube - Remember video quality): Not restoring remembered quality #2675

CoolCooler0 opened this issue Jan 30, 2024 · 37 comments · Fixed by #3879
Labels
Bug report Something isn't working

Comments

@CoolCooler0
Copy link

CoolCooler0 commented Jan 30, 2024

Bug description

Hello, after patching the new recommend version of YT with the latest patches the remember video quality patch doesn't work properly anymore.

1440p is my default quality preference I selected. And when it's not available on a video it chooses 1080p. But now if 1440p is not available it doesn't select the available highest video quality. It selects 360 or 480p.

Solution

Enable version spoofing (under ReVanced Settings -> General layout) and use spoof target 18.20.39

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@CoolCooler0 CoolCooler0 added the Bug report Something isn't working label Jan 30, 2024
@LisoUseInAIKyrios
Copy link
Contributor

I cannot reproduce the issue. Setting 1440p works correctly and uses the highest resolution up to 1440p.

It can take a few seconds for the UI quality picker to show the ReVanced default is set.

Many people have previously complained it's not applying the Revanced default, and it turned out they were opening the UI picker immediately after a video opened and all they needed to do was wait 5-10 seconds for the quality default to actually apply.

If it's never applying the highest resolution available, then it's possible YT is ignoring the initial patched call to change the quality.

You can try selecting 'higher picture quality' in the YT 'video quality preference' and maybe that will help. And you can try version spoofing (under ReVanced -> Layout) to 18.20.39 and maybe the behavior will be different.

@oSumAtrIX
Copy link
Member

I am reproducing this. I set the default to 4k, then start a video which is 720p at max. After some time YT defaults to 480p.

@oSumAtrIX
Copy link
Member

It's possible that on video load, the qualities are not available, and the patch attempting to set them is ignored by YouTube which then defaults to some other quality

@oSumAtrIX
Copy link
Member

A solution would involve hooking the method which is called when the qualities are loaded. At that point the patch could set the quality, if thats actually the problem

@LisoUseInAIKyrios
Copy link
Contributor

Or maybe YT is changing the video quality during playback. The remember quality patch only sets the quality once on video load.

Does spoofing to 18.20.39 or lower behave the same?

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Jan 30, 2024

As far as I know we hook the set quality method. We intercept the quality parameter through the patch, then call the video.setQuality method. We could find references to it and check if its being called.or hook that method

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title bug: Remember video quality patch not wokring correctly anymore. bug(YouTube - Remember video quality): Default video quality is not always applied Jan 30, 2024
@CoolCooler0

This comment was marked as spam.

@Domiiniik

This comment was marked as spam.

@NBruderman
Copy link

I experience this bug aswell. However, a method that helped me somewhat mitigate the issue, is to spoof player dimensions. It helps picking the higher quality (1440p and up) more consistently.

@LisoUseInAIKyrios
Copy link
Contributor

To anyone with this issue, try turning on version spoofing (under ReVanced Settings -> Layout), and try using spoof targets 18.20.39 and 18.09.39

And maybe or maybe not it will help.

@CoolCooler0
Copy link
Author

To anyone with this issue, try turning on version spoofing (under ReVanced Settings -> Layout), and try using spoof targets 18.20.39 and 18.09.39

And maybe or maybe not it will help.

Thanks, this is working. I spoof it to 18.20.39

@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Feb 9, 2024

Thanks, this is working. I spoof it to 18.20.39

Try manually setting the spoof target to 18.38.45, and verify that version also works.

To manually change the spoof target, go to ReVanced Settings -> Misc -> Import / Export and find:
"spoof_app_version_target": "18.20.39",

And change it to:
"spoof_app_version_target": "18.38.45",

Press the import button and restart the app.

Then report back if the default video quality is still fixed

@CoolCooler0
Copy link
Author

Thanks, this is working. I spoof it to 18.20.39

Try manually setting the spoof target to 18.38.45, and verify that version also works.

To manually change the spoof target, go to ReVanced Settings -> Misc -> Import / Export and find: "spoof_app_version_target": "18.20.39",

And change it to: "spoof_app_version_target": "18.38.45",

Press the import button and restart the app.

Then report back if the default video quality is still fixed

So after i switched it to 18.38.45 I experience something different. It starts at 720p60 and then go's to 1080p60. It will stay on 1080p60 for awhile and then switch to 1440p60 but sometimes it stays on 1080p60. This only happens on videos that is 60fps. And on other videos it will start at 1440p that are not 60fps. So does the 60fps part make a difference? Can someone else also confirm this please.

@LisoUseInAIKyrios
Copy link
Contributor

So does the 60fps part make a difference? Can someone else also confirm this please.

I can't confirm because I don't have the quality issue.

But if it's acting worse or inconsistent, then keep using 18.20.39. There are other advantages of that spoof target version anyways, such as restoring RYD for incognito Shorts and slightly faster loading of Shorts.

@CoolCooler0
Copy link
Author

So does the 60fps part make a difference? Can someone else also confirm this please.

I can't confirm because I don't have the quality issue.

But if it's acting worse or inconsistent, then keep using 18.20.39. There are other advantages of that spoof target version anyways, such as restoring RYD for incognito Shorts and slightly faster loading of Shorts.

Ok. I understand. And yes, I did set it back to 18.20.39 and it works perfectly thanks.

@oSumAtrIX
Copy link
Member

Looks like its the usual delay that occurs when starting videos. After some seconds it goes to the highest available quality.

@oSumAtrIX oSumAtrIX closed this as not planned Won't fix, can't repro, duplicate, stale Mar 12, 2024
@NBruderman
Copy link

It does it on the first video, but if the first video highest quality is, for example, 1080p, after switching to higher quality video, the quality will remain 1080p

@oSumAtrIX oSumAtrIX reopened this Mar 12, 2024
@oSumAtrIX oSumAtrIX changed the title bug(YouTube - Remember video quality): Default video quality is not always applied bug(YouTube - Remember video quality): Not restoring remembered quality Mar 12, 2024
@CoolCooler0

This comment was marked as spam.

@EMREOYUN
Copy link

Hello. This issue happening in 1080p and 720p as well. Youtube makes it 480p and does not restore after and it happens on every single video. What happens is video loads in remembered quality but falls back to 480p after a few seconds.

@CoolCooler0
Copy link
Author

CoolCooler0 commented May 12, 2024

Hello. This issue happening in 1080p and 720p as well. Youtube makes it 480p and does not restore after and it happens on every single video. What happens is video loads in remembered quality but falls back to 480p after a few seconds.

Yea its still happening. I just ignored it and choose the quality everytime myself. It has been an issue for a long time. But try the solution. See if it works for you. Spoof the app version to 18.20.39

@EMREOYUN
Copy link

Hello. This issue happening in 1080p and 720p as well. Youtube makes it 480p and does not restore after and it happens on every single video. What happens is video loads in remembered quality but falls back to 480p after a few seconds.

Yea its still happening. I just ignored it and choose the quality everytime myself. It has been an issue for a long time. But try the solution. See if it works for you. Spoof the app version to 18.20.39

Tried spoofing into 18.20.39, it looks stable. Video starts from 720p but changes back to prefered resolution after a few seconds.

@GKid94

This comment was marked as duplicate.

@CoolCooler0

This comment was marked as resolved.

@GKid94

This comment was marked as resolved.

@CoolCooler0

This comment was marked as resolved.

@GKid94

This comment was marked as resolved.

@CoolCooler0

This comment was marked as resolved.

@CoolCooler0
Copy link
Author

RVX dev has found a solution to this without spoofing the app version. I hope it can be implemented in Revanced aswell.

@captaingreen82
Copy link

RVX dev has found a solution to this without spoofing the app version. I hope it can be implemented in Revanced aswell.

Please share the solution of RVX.
I tried spoofing 18.20.39 but its not working for me.

@CoolCooler0
Copy link
Author

CoolCooler0 commented Aug 23, 2024

RVX dev has found a solution to this without spoofing the app version. I hope it can be implemented in Revanced aswell.

Please share the solution of RVX. I tried spoofing 18.20.39 but its not working for me.

RVX dev fixed it. I guess you will need to use RVX and patch YouTube with rvx patches. I don't why Revanced Dev don't implement it here to

@oSumAtrIX
Copy link
Member

Link the commit/fix

@CoolCooler0
Copy link
Author

Link the commit/fix

inotia00/ReVanced_Extended#2157

@oSumAtrIX
Copy link
Member

That does not fix the issue but work around it & causes stutter in the beginning of the video

@LisoUseInAIKyrios
Copy link
Contributor

I think this issue was fixed with #3879

@EMREOYUN
Copy link

I think this issue was fixed with #3879

Yep, it will match the probable cause I am suspecting. Not tested yet.

@andris155
Copy link

andris155 commented Nov 21, 2024

I viewed multiple times the quality, but after this patch Revanced always apply the selected quality or the highest available quality.

@CoolCooler0
Copy link
Author

It has been fixed. Thank you. Its working again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
9 participants