Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(TikTok): Feed Filter not Feed Filtering in Following tab #3246

Closed
3 tasks done
Mieridduryn opened this issue May 29, 2024 · 10 comments · Fixed by #3673
Closed
3 tasks done

bug(TikTok): Feed Filter not Feed Filtering in Following tab #3246

Mieridduryn opened this issue May 29, 2024 · 10 comments · Fixed by #3673
Labels
Bug report Something isn't working

Comments

@Mieridduryn
Copy link

Mieridduryn commented May 29, 2024

Bug description

Error during use, patch not behaving as expected.

After patching TikTok 32.5.3 with Revanced-CLI 4.6.0 with Revanced Patches 4.7.0, and then installing the resulting APK, advertisements are not properly filtered out of my Following feed when using the app. They are labeled "sponsored." They should not be there.

Steps to reproduce:

  1. Patch TikTok 32.5.3 (zhiliaoapp.musically) with Revanced CLI 4.6.0 and Revanced Patches 4.7.0. Revanced Integrations 1.8.0 was also used. I did not customize which patches were included, the defaults were fine for my needs.
    Patches included in my own apk:
  • Disable Login Requirement
  • Downloads
  • Feed Filter
  • Fix Google Login
  • Playback Speed
  • Remember Clear Display
  • Settings
  • Show Seekbar
  1. Patches will execute with no errors.
  2. Install the resulting APK on an Android device.
  3. Sign into TikTok.
  4. Tap on "Following" and scroll.
  5. Advertisements will appear.

For extra extra details, the device I patched the application on is running Linux Mint 21.3 Cinnamon and GNOME Terminal was used to run the patcher. The Android device I installed the patched application on is running Android 14 with OneUI 6.1.

Video of issue:
https://github.com/ReVanced/revanced-patches/assets/155842515/2f0d107c-371f-46ae-971e-ae4f41cda0c9

Error logs

No response

Solution

No response

Additional context

This issue has been reported before - #2632, where the issue was closed and a patch list + versions + video + steps to reproduce were requested. Please tell me what I can add to ensure that this issue is fixed if this information is insufficient.

#2534 reports the same issue and was closed for similar reasons.

I come bearing the necessary details so that hopefully, this issue can be solved once and for all.

Remove Feed Ads is turned on in the app's settings.

Acknowledgements

  • This issue is not a duplicate of an existing bug report.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@Mieridduryn Mieridduryn added the Bug report Something isn't working label May 29, 2024
@LisoUseInAIKyrios LisoUseInAIKyrios changed the title bug: (TikTok) Feed Filter not Feed Filtering in Following tab bug(TikTok): Feed Filter not Feed Filtering in Following tab Jun 2, 2024
@Mieridduryn
Copy link
Author

This also happens, on occasion, with viewing videos on someone's profile. It's just a lot less common there.

@oSumAtrIX oSumAtrIX linked a pull request Sep 21, 2024 that will close this issue
1 task
@oSumAtrIX oSumAtrIX removed a link to a pull request Sep 21, 2024
1 task
@oSumAtrIX
Copy link
Member

Should be fixed with the linked PR. If not, reopen.

@oSumAtrIX oSumAtrIX linked a pull request Sep 22, 2024 that will close this issue
1 task
@Mieridduryn
Copy link
Author

Problem persists after the update when viewing videos on someone's profile. Is this worth reopening this issue, or does it need a separate one?

@oSumAtrIX
Copy link
Member

A new issue would be good

@Mieridduryn
Copy link
Author

Actually... Nevermind, I have to ask that this issue be reopened, regardless.

TikTok 36.5.4, patched on Termux with Revancify this time. The exact same patches as I specified in my original post were applied here, as well. Revanced Patches 4.16.0, CLI 4.6.0, Patcher 20.0.0, Integrations 1.15.0. The issue hasn't popped up in a different area, it just hasn't been fully fixed. My bad.

@Mieridduryn
Copy link
Author

https://github.com/user-attachments/assets/79ed5ebb-3f0d-41f5-b984-3b3146f8f73a
Screen recording of the ads still popping up in the Following feed.

@oSumAtrIX
Copy link
Member

Unofficial tools are unsupported here

@Mieridduryn
Copy link
Author

Is Revancify not simply a more convenient UI shell for ReVanced on Termux?

I guess I'll have to redo the patch job on my laptop at some point.

@vavsvirtual
Copy link

I sent @Mieridduryn an APK I patched myself that does not present the bug as described in following on my device but it still does on theirs.

Versions used:

  • revanced cli 4.6.0
  • patches 4.16.0
  • integrations 1.15.0
  • com.zhiliaoapp.musically_36.5.4-2023605040_minAPI21(arm64-v8a,armeabi-v7a)

Patches applied:

  • Disable login requirement
  • Downloads
  • Feed filter
  • Fix Google login
  • Playback speed
  • Remember clear display
  • Settings
  • Show seekbar

Patching was done on Windows 11 in Powershell (Open JDK (21.0.3)) and completed with no errors. My device which is unable to replicate the bug is a Pixel 7 Pro on Android 15.

There's the potential this could be One UI related or even regional (I'm in UK, they're US) as we've experienced different behaviours with the same APK.

@Mieridduryn
Copy link
Author

Confirming what Vav said. I asked her to do some testing with me and provide her input in this thread. We installed the exact same APK. I'm on OneUI 6.1, Android 14, but I'm not sure what she's on.

I am also experiencing, on the same app that she patched and sent over to me, ads playing after videos. Not fun!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants