Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Open Links with App Chooser patch breaks while patching on X(Twitter) #3466

Closed
2 of 3 tasks
feralfenrir opened this issue Jul 22, 2024 · 2 comments
Closed
2 of 3 tasks
Labels
Bug report Something isn't working

Comments

@feralfenrir
Copy link

feralfenrir commented Jul 22, 2024

Bug description

The latest release build for X with an APK available is v10.49.0.

This build breaks the Open Links with App Chooser patch while building.

Error logs

- Device Info
ReVanced Manager: 1.20.1
Model: Pixel 7 Pro
Android version: 14
Supported architectures: arm64-v8a
Root permissions: No

- Patch Info
App: com.twitter.android v10.49.0-release.0 (Suggested: Any)
Patches version: v4.11.0
Patches added: Open links with app chooser
Patches removed: None
Default patch options changed: None

- Settings
Allow changing patch selection: true
Version compatibility check: true
Show universal patches: false
Patches source: revanced/revanced-patches
Integration source: revanced/revanced-integrations

- Logs
Reading APK
Decoding app manifest
Loading patches
Merging integrations
Deleting existing temporary files directory
Decoding resources
Executing patches
Applied 5 patches
Open links with app chooser failed: app.revanced.patcher.patch.PatchException: Failed to resolve OpenLinkFingerprint
	at app.revanced.util.BytecodeUtilsKt.getException(BytecodeUtils.kt:27)
	at app.revanced.patches.twitter.misc.links.OpenLinksWithAppChooserPatch.execute(OpenLinksWithAppChooserPatch.kt:33)
	at app.revanced.patches.twitter.misc.links.OpenLinksWithAppChooserPatch.execute(OpenLinksWithAppChooserPatch.kt:11)
	at app.revanced.patcher.Patcher$apply$1.invokeSuspend$executePatch(Unknown Source:190)
	at app.revanced.patcher.Patcher$apply$1.invokeSuspend(Unknown Source:292)
	at app.revanced.patcher.Patcher$apply$1.invoke(SourceFile:0)
	at app.revanced.patcher.Patcher$apply$1.invoke(SourceFile:0)
	at kotlinx.coroutines.flow.SafeFlow.collectSafely(Unknown Source:2)
	at kotlinx.coroutines.flow.AbstractFlow.collect(Unknown Source:71)
	at app.revanced.manager.flutter.MainActivity$runPatcher$1$patcherResult$1$2.invokeSuspend(Unknown Source:76)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(Unknown Source:11)
	at kotlinx.coroutines.DispatchedTask.run(Unknown Source:93)
	at kotlinx.coroutines.EventLoopImplBase.processNextEvent(Unknown Source:46)
	at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Unknown Source:23)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Unknown Source:73)
	at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source:0)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Unknown Source:6)
	at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source:0)
	at app.revanced.manager.flutter.MainActivity.runPatcher$lambda$34(Unknown Source:470)
	at app.revanced.manager.flutter.MainActivity.$r8$lambda$hTJfH-rv2j-9Y91G5H_L5jFDN6U(SourceFile:0)
	at app.revanced.manager.flutter.MainActivity$$ExternalSyntheticLambda5.run(SourceFile:0)
	at java.lang.Thread.run(Thread.java:1012)
Compiling patched dex files
Compiled 12 dex files
Compiling modified resources
Canceling patching process
Press back to exit

Solution

No response

Additional context

No response

Acknowledgements

  • I have checked all open and closed bug reports and this is not a duplicate.
  • I have chosen an appropriate title.
  • All requested information has been provided properly.
@feralfenrir feralfenrir added the Bug report Something isn't working label Jul 22, 2024
@feralfenrir
Copy link
Author

The last build that works is v10.48.0-release

@cyberboh
Copy link

Close this
Already reported here #3431

Make sure you did a search before post any bugs/requests

@oSumAtrIX oSumAtrIX closed this as not planned Won't fix, can't repro, duplicate, stale Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug report Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants