bug(X / Twitter - Change sharing link): Crash upon clicking share button when Change sharing link patch is enabled

[obipoketbobo]

Bug description

X/Twitter crashes upon clicking the Share button when Change sharing link is enabled
All non-universal patches are enabled besides "Open links in app chooser"

Error logs

Solution

No response

Additional context

No response

Acknowledgements

• I have checked all open and closed bug reports and this is not a duplicate.
• I have chosen an appropriate title.
• All requested information has been provided properly.

[obipoketbobo]

where is the duplicate issue? I don't see an open issue relating to this bug even though the bug is still present

[aliernfrog]

It looks like the extensions are located in the wrong class: app.revanced.twitter.* instead of app.revanced.extension.twitter.*

Would create a PR but I currently do not have a setup to fix/test it.

[cyberboh]

Logs if needed:

12-20 08:40:03.731 15632 15632 E AndroidRuntime: FATAL EXCEPTION: main
12-20 08:40:03.731 15632 15632 E AndroidRuntime: Process: com.twitter.android, PID: 15632
12-20 08:40:03.731 15632 15632 E AndroidRuntime: java.lang.NoClassDefFoundError: Failed resolution of: Lapp/revanced/extension/twitter/patches/links/ChangeLinkSharingDomainPatch;
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at zyu.d(Twttr:31)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at wxu.c(Twttr:10)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at nuu.H1(Twttr:72)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at e9a.call(Twttr:200)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at idv.q(Twttr:17)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at wbv.b(Twttr:3)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at sfv.q(Twttr:62)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at wbv.b(Twttr:3)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at hdv.subscribeActual(Twttr:13)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at s5n.subscribe(Twttr:11)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at h7n.subscribeActual(Twttr:12)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at s5n.subscribe(Twttr:11)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at q9n.subscribeActual(Twttr:26)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at s5n.subscribe(Twttr:11)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at s5n.subscribe(Twttr:6)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at s5n.subscribe(Twttr:2)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at com.twitter.app.share.ui.ShareSheetViewDelegateBinder.c(Twttr:127)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at ovu.E1(Twttr:23)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at androidx.fragment.app.l.n(Twttr:153)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at androidx.fragment.app.l.k(Twttr:59)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at androidx.fragment.app.j.A(Twttr:1039)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at androidx.fragment.app.j.a0(Twttr:92)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at androidx.fragment.app.j.y(Twttr:74)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at androidx.fragment.app.j$f.run(Twttr:4)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at android.os.Handler.handleCallback(Handler.java:900)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:103)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:219)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at android.app.ActivityThread.main(ActivityThread.java:8668)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at java.lang.reflect.Method.invoke(Native Method)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:513)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1109)
12-20 08:40:03.731 15632 15632 E AndroidRuntime: Caused by: java.lang.ClassNotFoundException: app.revanced.extension.twitter.patches.links.ChangeLinkSharingDomainPatch
12-20 08:40:03.731 15632 15632 E AndroidRuntime: 	... 31 more

[LisoUseInAIKyrios]

Patches is using the wrong class package name:

revanced-patches/patches/src/main/kotlin/app/revanced/patches/twitter/misc/links/ChangeLinkSharingDomainPatch.kt

Lines 30 to 35 in 99f4e4d

	"Lapp/revanced/extension/twitter/patches/links/ChangeLinkSharingDomainPatch;->" +
	"formatResourceLink([Ljava/lang/Object;)Ljava/lang/String;"
	// This method is used to build the link that is shared when the "Copy link" button is pressed.
	private const val FORMAT_METHOD_REFERENCE =
	"Lapp/revanced/extension/twitter/patches/links/ChangeLinkSharingDomainPatch;->" +

revanced-patches/extensions/twitter/src/main/java/app/revanced/twitter/patches/links/ChangeLinkSharingDomainPatch.java

Line 1 in 99f4e4d

package app.revanced.twitter.patches.links;

Edit: Already identified by Aliern above