-
-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug(YouTube - Force original audio): Audio playback issues with IOS client for videos with dubbed audio due to default audio stream language selection #4154
Comments
This is also an issue on Android 14 (S23 Ultra). Here even more is broken. Option set for all use-cases: This is the default setting for Android
This is not the default setting for Android
|
Pixel 8 Pro Android VR spoof + force original audio enabled works as intended on my end: With German system and app language, opening a video that has English original audio and shows an automatically translated video title, it plays fine with the original English audio stream. Switching over to iOS Spoofing will give the same issues as mentioned in the initial bug description. |
Force original language not working when using a non-english default because YouTube uses localized text for the name "Original": (English default spoof language): (Germany default): (Bengali default):
Edit: Never mind I found one. |
iOS should be fixed on dev. Needs verification from other users as I only checked with a few videos. Android VR does not have multiple audio streams, so force original audio is not possible. |
@Karthik-Subbu please patch using dev release and a computer, command line, and CLI tools, and verify the issue is fixed. |
Thank you.. Looks fine.. just a couple of queries:
|
The audio flyout menu is missing if Android VR spoofing is selected. If it's missing with iOS spoofing then provide a video where this happens. Force original audio and spoof video stream are different patches so it's a little clunky getting one patch to 'know' another patch was included or not. Changing the default spoof to iOS would make graying out force audio not important, since the user would need to first opt into android VR and they'll see the side effect disclaimer then. |
Audio track flyout menu missing happens sometimes when YouTube is launched by clicking a video url. The same time statsfornerds also renders incomplete information as seen in the attachment. This may be due to other reasons and not related to the patch. So I think we can consider this issue closed for now. |
Bug description
Following behavior is observed with default IOS client for spoof video streams:
case (1)
Sample video: https://youtu.be/NHUTmP9Tr2A , original audio track is in English. Dubbed audio tracks are available in French, German, Italian, Portuguese (Brazil) and Spanish.
a) Force original audio language (which is English) turned on. Default audio stream language set to German (one of the available dubbed audio tracks). Actual audio playback starts in French and falls back to Italian after few seconds. Forcing is not working properly. (Maybe ISO language code for German and the google recognized code for German are different? ) Disabling force original audio language results in audio playback in German.
b) Force original audio language (which is English) turned on. Default audio stream language set to French (one of the available dubbed audio tracks). Actual audio playback language observed: English. Forcing is working properly. Disabling force original audio language results is audio playback in French.
c) Force original audio language (which is English) turned on. Default audio stream language set to Korean (Language other than available dubbed audio tracks). Actual audio playback starts in French and falls back to Italian. Forcing is not working properly. Disabling force original audio language results in audio playback in English.
case (2)
Sample video: https://youtu.be/uZLY6DL5owY, original audio track is in German. Dubbed audio track is available in English.
a) To investigate language code issue in case 1(A) further, Force original audio language (which is German) turned on. Default audio stream language is also set to German. Ideally there shouldn't be any change in audio playback language. But the audio playback starts in German and changes over to English in few seconds which confirms issue in language code for German.
b) Force original audio language (which is German) turned on. Default audio stream language set to English (one of the available dubbed audio tracks). Actual audio playback language observed: German. Forcing is working properly.
c) Force original audio language (which is German) turned on. Default audio stream language set to Korean (Language other than available dubbed audio tracks). Actual audio playback starts in German and falls back to English. Forcing is not working properly. Disabling force original audio language results in audio playback in German.
Conclusion:
Error logs
Solution
a) IOS client already allows switching between audio tracks if user wishes to change audio track language.
b) Android VR client at the moment doesn't utilize a language code for spoofing.
Force original audio has to take priority over other language related settings.
It would be appropriate if the option to "Force original audio" is moved to spoof video streams setting and the option enabled only if IOS client is selected.
Additional context
No response
Acknowledgements
The text was updated successfully, but these errors were encountered: