Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ram Size Option follow up #139

Closed
JPrendy opened this issue Mar 26, 2021 · 7 comments · Fixed by #165
Closed

Ram Size Option follow up #139

JPrendy opened this issue Mar 26, 2021 · 7 comments · Fixed by #165

Comments

@JPrendy
Copy link
Contributor

JPrendy commented Mar 26, 2021

Hi there,

I noticed some improvements in my builds since the merging of this pr Add option to modify the number of cores.

Just wondering the same author created a pr Add ram size option but closed it. Is that something you can look into for this action. I am not sure if the author found any negatives when working on the feature, but it looks like an interesting feature to add to the runner.

@ychescale9
Copy link
Member

CC @AfzalivE

@AfzalivE
Copy link
Contributor

AfzalivE commented Mar 26, 2021

I'll push it later today or this weekend. I added a lot of options so I wasn't sure which ones you'd like.

@ychescale9

Would you like these in addition to the ram size option?

  • disable-spellchecker
  • disable-autofill
  • longpress-timeout
  • enable-hw-keyboard
  • enable-logcat (reads and saves the logcat to artifacts/logcat.log)
  • print-config-ini (this one is probably not so useful)
  • vm-heap-size (this one was pretty useless since the system_server VM heap was unaffected by changing this :( )

@ychescale9
Copy link
Member

Thanks @AfzalivE ! Let's add the following for now :)

  • ram-size
  • disable-spellchecker
  • longpress-timeout
  • enable-hw-keyboard

@andreRBarata
Copy link

Hi there,

I was wondering if this update was being looked at at the moment or if its in the back burner?

Expecially the ram-size one

@ychescale9
Copy link
Member

I can take a look this weekend, unless @AfzalivE wants to continue his work here?

@AfzalivE
Copy link
Contributor

AfzalivE commented Jun 25, 2021

Really sorry that I've been missing from this project for a while and I'm not going to be home this weekend :(

We also switched to firebase test lab, because of this I haven't been able to dedicate time to project.

The Doist fork should have everything you need.

@ychescale9
Copy link
Member

ram-size is now available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants