Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible problem with OperatorRetry and nested subscription #1024

Closed
petermd opened this issue Apr 8, 2014 · 2 comments
Closed

possible problem with OperatorRetry and nested subscription #1024

petermd opened this issue Apr 8, 2014 · 2 comments

Comments

@petermd
Copy link
Contributor

petermd commented Apr 8, 2014

as reported on the Group there is a problem with OperatorRetry in combination with other operators.

i think the issue might be because OperatorRetry re-uses the child Subscriber inner CompositeSubscription causing it to be inadvertently completed (so re-subscribe fails).

https://github.com/Netflix/RxJava/blob/master/rxjava-core/src/main/java/rx/operators/OperatorRetry.java#L85

I've added a test and the suggested fix (just use a new Subscriber) which does address the problem.

petermd@d9fef71

FYI Might also be related #1023.

@zsxwing
Copy link
Member

zsxwing commented Apr 9, 2014

Thank you. I think you are right. I added some comment on your commit. Could you send a RP?

@benjchristensen
Copy link
Member

Fixed in #1027

Thanks @petermd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants