Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inverted onError and onComplete in Completable #4137

Closed
lukasz-gosiewski opened this issue Jun 27, 2016 · 2 comments
Closed

Inverted onError and onComplete in Completable #4137

lukasz-gosiewski opened this issue Jun 27, 2016 · 2 comments
Labels
Duplicate

Comments

@lukasz-gosiewski
Copy link

In completable subscribe method there is inverted order of methods (in compare to ex. Observable). In every other classes there is onNext/onSucces first, and in Completable there is onError first.
@vanniktech
Copy link
Collaborator

Dupe of #3851

@akarnokd
Copy link
Member

Closing as duplicate. If you have time, you could post a PR that swaps the params as described in #3851.

@artem-zinnatullin artem-zinnatullin mentioned this issue Jun 27, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@akarnokd @lukasz-gosiewski @vanniktech