Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.x Single.flatMapCompletable expects Completable instead of CompletableSource #4923

Closed
vanniktech opened this issue Dec 16, 2016 · 3 comments · Fixed by #4924
Closed

2.x Single.flatMapCompletable expects Completable instead of CompletableSource #4923

vanniktech opened this issue Dec 16, 2016 · 3 comments · Fixed by #4924
Labels
2.x Bug PR welcome
Milestone
2.x backlog

Comments

@vanniktech
Copy link
Collaborator

The signature looks like this:

final Function<? super T, ? extends Completable> mapper

although it should be

final Function<? super T, ? extends CompletableSource> mapper
@akarnokd akarnokd added this to the 2.0 backlog milestone Dec 16, 2016
@akarnokd
Copy link
Member

I don't think there are any CompletableSource implementations other than RxJava but you are welcome to send a PR.

@vanniktech
Copy link
Collaborator Author

Well it's mostly for consistency and I'll send one right away.

@vanniktech vanniktech mentioned this issue Dec 16, 2016
Merged
@akarnokd
Copy link
Member

Closing via #4924

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.x Bug PR welcome
Projects
None yet
Milestone
2.x backlog
Development

Successfully merging a pull request may close this issue.

2.x: Change Completable to CompletableSource
2 participants
@akarnokd @vanniktech