Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.1.5 release preparation #5635

Closed
akarnokd opened this issue Oct 3, 2017 · 3 comments
Closed

2.1.5 release preparation #5635

akarnokd opened this issue Oct 3, 2017 · 3 comments

Comments

@akarnokd
Copy link
Member

akarnokd commented Oct 3, 2017

Note that there might be a couple of 2.1.5-RCx tags before this release in order to iron out the nebula-plugin free release process.

Version 2.1.5 - October 5, 2017 (Maven)

API changes

  • Pull 5616: Add Single.delay overload that delays errors.
  • Pull 5624: add onTerminateDetach to Single and Completable.

Documentation changes

  • Pull 5617: Fix Observable.delay & Flowable.delay javadoc.
  • Pull 5637: Fixing JavaDoc warnings.
  • Pull 5640: Additional warnings for fromPublisher().

Bugfixes

  • No bugs were reported.

Other

  • Pull 5615: Add missing license headers.
  • Pull 5623: Fix incorrect error message in SubscriptionHelper.setOnce
  • Pull 5633: Upgrade to Gradle 4.2.1, remove nebula plugin, replace it with custom release logic.
@akarnokd akarnokd added this to the 2.2 milestone Oct 3, 2017
@akarnokd
Copy link
Member Author

akarnokd commented Oct 3, 2017

FYI: RC4 finally managed to release to maven central without errors: https://travis-ci.org/ReactiveX/RxJava/builds/282648040

@artem-zinnatullin
Copy link
Contributor

cc Netflix team: RC-4 doesn't have <properties> in the pom.xml that 2.1.4 had:

 <properties>
    <nebula_Manifest_Version>1.0</nebula_Manifest_Version>
    <nebula_Implementation_Title>io.reactivex.rxjava2#rxjava;2.1.4</nebula_Implementation_Title>
    <nebula_Implementation_Version>2.1.4</nebula_Implementation_Version>
    <nebula_Built_Status>integration</nebula_Built_Status>
    <nebula_Built_By>travis</nebula_Built_By>
    <nebula_Built_OS>Linux</nebula_Built_OS>
    <nebula_Build_Date>2017-09-22_09:03:52</nebula_Build_Date>
    <nebula_Gradle_Version>2.14</nebula_Gradle_Version>
    <nebula_Module_Owner>[email protected]</nebula_Module_Owner>
    <nebula_Module_Email>[email protected]</nebula_Module_Email>
    <nebula_Module_Source></nebula_Module_Source>
    <nebula_Module_Origin>https://github.com/ReactiveX/RxJava.git</nebula_Module_Origin>
    <nebula_Change>3e33000</nebula_Change>
    <nebula_Branch>3e3300049dff23b15fa7f6639c844615a0b76f81</nebula_Branch>
    <nebula_Build_Host>testing-gce-49a1561b-b1d2-4225-9e33-fb4d4835d959</nebula_Build_Host>
    <nebula_Build_Job>LOCAL</nebula_Build_Job>
    <nebula_Build_Number>LOCAL</nebula_Build_Number>
    <nebula_Build_Id>LOCAL</nebula_Build_Id>
    <nebula_Created_By>1.8.0_144-b01 (Oracle Corporation)</nebula_Created_By>
    <nebula_Build_Java_Version>1.8.0_144</nebula_Build_Java_Version>
    <nebula_X_Compile_Target_JDK>1.6</nebula_X_Compile_Target_JDK>
    <nebula_X_Compile_Source_JDK>1.6</nebula_X_Compile_Source_JDK>
  </properties>

I don't think someone consumes them though.


Another difference is that RC4 doesn't have META-INF/rxjava.properties in the jar that 2.1.4 has:

Manifest-Version=1.0
Implementation-Title=io.reactivex.rxjava2#rxjava;2.1.4
Implementation-Version=2.1.4
Built-Status=integration
Built-By=travis
Built-OS=Linux
Build-Date=2017-09-22_09:03:52
Gradle-Version=2.14
Module-Owner[email protected]
Module-Email[email protected]
Module-Source=
Module-Origin=https://github.com/ReactiveX/RxJava.git
Change=3e33000
Branch=3e3300049dff23b15fa7f6639c844615a0b76f81
Build-Host=testing-gce-49a1561b-b1d2-4225-9e33-fb4d4835d959
Build-Job=LOCAL
Build-Number=LOCAL
Build-Id=LOCAL
Created-By=1.8.0_144-b01 (Oracle Corporation)
Build-Java-Version=1.8.0_144
X-Compile-Target-JDK=1.6
X-Compile-Source-JDK=1.6

And final noticeable difference I see is that META-INF/MANIFEST.MF in the jar has different values of some keys that are most likely important for OSGI support:

  • Bundle-Vendor was — ReactiveX, now — RxJava Contributors
  • Import-Package was — org.reactivestreams;version="[1.0,2)", now — lots of inner RxJava packages

Plus it misses meta info like X-Compile-Target-JDK, X-Compile-Source-JDK, Change, Module-Origin, etc.


You can download files from maven central to make own comparison.

@akarnokd
Copy link
Member Author

akarnokd commented Oct 3, 2017

I don't know about the nebula properties, but we no longer use nebula. The rxjava.properties also looks like a copy of those nebula properties which RxJava itself never used. Android folks no longer have to fear the duplication of rxjava.properties I guess.

The manifest is controlled by this part of the build.

@akarnokd akarnokd closed this as completed Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants