From 1cc10707532818fb81a62039c87bd82273f932df Mon Sep 17 00:00:00 2001 From: Nicholas Jamieson Date: Sat, 15 Sep 2018 08:02:41 +1000 Subject: [PATCH] chore(Subscriber): remove _addParentTeardownLogic --- spec/Subscriber-spec.ts | 4 ++-- src/internal/Subscriber.ts | 7 +------ 2 files changed, 3 insertions(+), 8 deletions(-) diff --git a/spec/Subscriber-spec.ts b/spec/Subscriber-spec.ts index a78959f39cc..a885fffaf3d 100644 --- a/spec/Subscriber-spec.ts +++ b/spec/Subscriber-spec.ts @@ -23,8 +23,8 @@ describe('Subscriber', () => { it('should accept subscribers as a destination if they meet the proper criteria', () => { const fakeSubscriber = { [rxSubscriber](this: any) { return this; }, - _addParentTeardownLogic() { /* noop */ }, - add() { /* noop */ } + add() { /* noop */ }, + syncErrorThrowable: false }; const subscriber = new Subscriber(fakeSubscriber as any); diff --git a/src/internal/Subscriber.ts b/src/internal/Subscriber.ts index be563c8c2a5..6ff55e7adc0 100644 --- a/src/internal/Subscriber.ts +++ b/src/internal/Subscriber.ts @@ -154,11 +154,6 @@ export class Subscriber extends Subscription implements Observer { this.unsubscribe(); } - /** @deprecated This is an internal implementation detail, do not use. */ - _addParentTeardownLogic(parentTeardownLogic: TeardownLogic) { - /*noop*/ - } - /** @deprecated This is an internal implementation detail, do not use. */ _unsubscribeAndRecycle(): Subscriber { const { _parent, _parents } = this; @@ -315,5 +310,5 @@ export class SafeSubscriber extends Subscriber { } function isTrustedSubscriber(obj: any) { - return obj instanceof Subscriber || ('_addParentTeardownLogic' in obj && obj[rxSubscriberSymbol]); + return obj instanceof Subscriber || ('syncErrorThrowable' in obj && obj[rxSubscriberSymbol]); }