Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing observable has very large timeframe #1965

Closed
kwonoj opened this issue Sep 21, 2016 · 2 comments
Closed

Testing observable has very large timeframe #1965

kwonoj opened this issue Sep 21, 2016 · 2 comments

Comments

@kwonoj
Copy link
Member

kwonoj commented Sep 21, 2016

RxJS version:
beta.12

Additional information:

let's say one of observable to be tested have relatively long timeframe such as

source = cold('1--2--#');
notifier = Observable.timer(10 * 1000, testScheduler) //expect retry after 10sec

expected = ???
expectObservable(source.retryWhen(notifier)).toBe(expected);

first, since TestScheduler limits maximum virtual frame less than 1000, retry logic won't be flushed by testScheduler. Secondly, it is hard to draw marble diagram for expected values even scheduler supports it since timeframe becomes excessively long.

I think it's not general, frequent cases though - is there any possible representation for this cases?

@kwonoj kwonoj changed the title Testing observable can have very large timeframe Testing observable has very large timeframe Sep 21, 2016
@kwonoj
Copy link
Member Author

kwonoj commented Oct 3, 2016

I'll aggregate this into #1775, which'll discuss revised interface allows similar scenario as well.

@kwonoj kwonoj closed this as completed Oct 3, 2016
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant